3675 - [PP]Opening the bookmarks window replaces the Navigator window

Status: VERIFIED FIXED

(Core Graveyard :: Tracking, defect, P2)

Description

[Mike Pinkerton (not reading bugmail)]

Launch apprunner and use the "Edit Bookmarks" menu item to bring up a new
bookmarks window. Move the window so that you can see the original browser
window, and you'll see that it too is a bookmarks window. This is on mac

On linux, a second window isn't opened. The main window becomes the bookmarks
window.

Comment 1

[Mike Pinkerton (not reading bugmail)]

This works fine on win32.

Comment 2

[Peter Trudelle]

reassigning to danm as p2 for m3

Comment 3

[Mike Pinkerton (not reading bugmail)]

it's not just bookmarks. choosing "messenger" from the apps menu does the same
thing.

Comment 4

[Mike Pinkerton (not reading bugmail)]

Ok, I was wrong. On MacOS, it opens two bookmarks windows (one covering your old
window). The old browser window is still there. On linux, however, there really
is only one window.

Comment 5

[Mike Pinkerton (not reading bugmail)]

The mac problem (which was actually all menu events were being dispatched twice,
yes, it is really was totally different bug) is now fixed.

Marking this as a linux bug and changing the title to reflect it.

Comment 6

[Dan M]

Current status: I have a fix on my local build which seems to work.  I'm in an overnight discussion with GTK Pavlov about it -- he has some worries about what I'm
doing.  So the problem is known, a (perhaps inappropriate but functional) solution is also known.  One way or another, it'll be all better in time for M3.

Comment 7

[Dan M]

This is bandaided to work for now.  The real problem is a miscommunication
between the three platforms about what it means to have a top-level window with
a parent.  Parents for top-level windows have been disabled, so the bookmarks
window will now show up in a separate window.  We need a real solution to the
actual problem; hopefully next week.

(But a note for the eager-to-test: you generally can't open the bookmarks window
on Linux.  See bug 3716.)

Comment 8

[Dan M]

re-opening and moving to M4.  As noted above, the symptom of the problem has been fixed and remains fixed.  We'd like a real fix for the future.  Also note that bug
3716 mentioned above seems to be a problem no longer today.

Comment 9

[leger]

updating QA Contact.

Comment 10

[Claudius Gayle]

to what does this refer to now? Is 'Edit Bookmarks' supposed to be Bookmarks|Manage Bookmarks? The behavior is different now
isn't it? This have been changed to work properly, no?

Comment 11

[Dan M]

Yes, he says conversationally, we're talking about Bookmarks/Manage Bookmarks.  It appears to behave
correctly, but this is accomplished by obscuring another problem.  Window parentage is currently
disabled.  That's a nice thing whose absence will soon be missed.  If we re-enable it, this bookmarks
problem comes back.  It's still unfixed.  It might more appropriately be a new and different bug.

Comment 12

[leger]

Moving all Apprunner bugs past and present to Other component temporarily whilst
don and I set correct component.  Apprunner component will be deleted/retired
shortly.

Comment 13

[Dan M]

This one's so old I don't remember what the problem was.  I do know that the symptom has been fixed,
and the underlying problem that I wanted to leave this bug open to remind me about, that being that
top-level windows couldn't have parents, has just now been fixed.  Parent information is no longer
being thrown away and everybody's happy now. Closing.

Comment 14

[Claudius Gayle]

I've been waiting for this actually, it's stained on my whiteboard now.
Is the 'parents o' top level windows' stuff checked in (and turned on)? If so when cuz, that
way I can make sure the Bookmarks aren't broken and this very old bug will finally go away.

Comment 15

[Claudius Gayle]

Marking VERIFIED for 1999081609 builds