367504 - Hang with -moz-inline-block, float ("yikes! spinning on a line over 1000 times!")

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Jesse Ruderman]

Attachment: testcase

Debug:

* Lots of ###!!! ASSERTION: aFrame is already associated with a region: '!GetFrameInfoFor(aFrame)', file /Users/admin/trunk/mozilla/layout/generic/nsSpaceManager.cpp, line 812

* Block(tbody)(1)@0x2ebcf84: yikes! spinning on a line over 1000 times!

* ###!!! ABORT: file /Users/admin/trunk/mozilla/layout/generic/nsBlockFrame.cpp, line 3137


Opt:

* Hang.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Looks like somebody needs to set NS_BLOCK_SPACE_MGR and probably NS_BLOCK_MARGIN_ROOT on inline blocks.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Yeah, http://www.w3.org/TR/CSS21/box.html#collapsing-margins says:

 *  Margins of inline-block elements do not collapse (not even with their
    in-flow children). 

and http://www.w3.org/TR/CSS21/visuren.html#q15 says that inline blocks establish new block formatting contexts.

I need to add some tests for these, but I'll probably put them in the patch for bug 9458.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(And this seems pretty safe for branches to me.)

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Checked in to trunk.

Comment 6

[Jay Patel [:jay]]

Comment on attachment 252079 [details] [diff] [review]
patch

Approved for both branches, a=jay for drivers.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Checked in to MOZILLA_1_8_BRANCH and MOZILLA_1_8_0_BRANCH.

Comment 8

[Martijn Wargers (dead)]

Verified fixed on trunk, I did hang with a 2007-01-22 build, but not anymore with a 2007-01-23 build.
On branch builds, the testcase doesn't hang before and after the patch went in.
I checked with the branch cvs logs that the patch went in.

Comment 9

[Jesse Ruderman]

dbaron checked two reftests for this bug in when he landed the fix for bug 9458.

http://lxr.mozilla.org/mozilla/find?string=367504