367614 - [Win Only] The composition string for IME should have dashed underline

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away: 6/25-6/28)]

The composition string for IME should have dashed underline only on Windows. Because on Windows, the style of composition style depends on the settings of IME. And the applications cannot get the settings in *all* IMEs. Therefore, the applications of Microsoft (e.g., IE, wordpad and Word) are rendering the composition string with underline which style is dashed.

Therefore, we should use same style on Gecko. But we cannot draw the dashed underline in current code. However, the patch for bug 365336 supports the dashed underline. So, we can fix this bug after bug 365336.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away: 6/25-6/28)]

Attachment: Patch rv1.0

fix.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Why don't you just return NS_STYLE_BORDER_STYLE_ values from nsILookAndFeel instead of defining new NS_UNDERLINE_STYLE_ constants for them?

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away: 6/25-6/28)]

NS_STYLE_BORDER_STYLE_ cannot use without including the layout/style header. And they have some invalid values (ridge, groove, inset and outset), I want to spread the this prefs to JP-users. Therefore, the values should be simple.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away: 6/25-6/28)]

And I also think that we will implement the style for decoration lines in CSS3, we should use same values as them.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away: 6/25-6/28)]

roc:

there are two ways:

1. we use the style consts of border (with including the header file).
2. we use original value like the current patch.

If we use (1), the valid values of the prefs are not continuously. I think that this is not usable for the users. And this way will not be smart after bug 59109. Because if use same values in the text-decoration styles after it, we need to change the meanings of values. Or we need to continue to use the border-style for decoration-style.

I believe that (2) is better. (or in layout/style, we define the consts before the bug.)

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away: 6/25-6/28)]

checked-in.