367654 - Param('upgrade_notification') eq 'development_snapshot' should catch release candidates too if no development snapshot is available

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect)

Description

[Frédéric Buclin]

Attachment: patch, v1

When we will release Bugzilla 3.0rc1, there will be no development snapshot (i.e. Bugzilla 3.1.1 won't be released yet) and so our notification system won't report any new release to installations having Param('upgrade_notification') eq 'development_snapshot' despite it should. So the correct behavior is to look for RCs if there is no development snapshot available, because this means we are at the point where we are going to branch. As soon as a development snapshot is available, the notification system should again look at it instead of the RCs.

Comment 1

[Max Kanat-Alexander]

Comment on attachment 252216 [details] [diff] [review]
patch, v1

There can be development snapshots and release candidates at the same time--how should people be notified then? For example, will the system *ever* notify *anybody* about 3.0rc2 if 3.1.1 is out?

Comment 2

[Max Kanat-Alexander]

Comment on attachment 252216 [details] [diff] [review]
patch, v1

OK, after discussion on IRC, I've decided that this is fine, but we need to fix the branch release stuff in a separate bug.

Comment 3

[Frédéric Buclin]

(In reply to comment #1)
> (From update of attachment 252216 [details] [diff] [review])
> There can be development snapshots and release candidates at the same time--how
> should people be notified then? For example, will the system *ever* notify
> *anybody* about 3.0rc2 if 3.1.1 is out?

If you have 3.0rc1 installed, and your param is set to stable_branch_release, you get notification for 3.0rc2, not 3.1.1.

Comment 4

[Frédéric Buclin]

Checking in Bugzilla/Update.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Update.pm,v  <--  Update.pm
new revision: 1.5; previous revision: 1.4
done