367657 - Remove old DOM Inspector shared library when upgrading

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Peter Weilbacher]

Attachment: Add DOMI library to list of files to remove

Bug 338746 removed the old DOM-I library that got merged into gklayout from the package* files but did not add it to the list of files to delete when updating from an old version. That causes crashes at least on OS/2.

The patch adds it for Unix, Windows, and OS/2, not sure what I have to do about Mac or even what filename it has there.

Comment 1

[Andrew Schultz]

Comment on attachment 252220 [details] [diff] [review]
Add DOMI library to list of files to remove

r=me

Comment 2

[Peter Weilbacher]

Could someone please check this in? I am supposed to restrict myself to OS/2-only stuff...

Comment 3

[Andrew Schultz]

Comment on attachment 252220 [details] [diff] [review]
Add DOMI library to list of files to remove

>Index: xpinstall/packager/windows/browser.jst
>+    deleteThisFile("Components", "inspector.dll");

Actually, with my new-found understanding of the windows installer (see bug 367657), I realize this should go into the previous section of browser.jst (before |if (!gGreLocal)|).  With this patch, inspector.dll would not be deleted since the installer is now local by default.

I'll commit with this fixup later tonight, unless someone beats me to it.

Comment 4

[Andrew Schultz]

Comment on attachment 252220 [details] [diff] [review]
Add DOMI library to list of files to remove

landed on trunk (I also moved the unix/os2 lines up with the other libs)

Comment 5

[Andrew Schultz]

Attachment: what I checked in, merged to 1.8 branch

bug 325100 landed on the branch, so we need this on the branch too.

Comment 6

[Robert Kaiser]

Comment on attachment 252967 [details] [diff] [review]
what I checked in, merged to 1.8 branch

first-a=me for 1.1.1, still one needed to go

Comment 7

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Comment on attachment 252967 [details] [diff] [review]
what I checked in, merged to 1.8 branch

a=me for 1.1.1