Closed Bug 367657 Opened 15 years ago Closed 15 years ago

Remove old DOM Inspector shared library when upgrading

Categories

(SeaMonkey :: Installer, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mozilla, Unassigned)

Details

(Keywords: fixed-seamonkey1.1.1)

Attachments

(1 file, 1 obsolete file)

Bug 338746 removed the old DOM-I library that got merged into gklayout from the package* files but did not add it to the list of files to delete when updating from an old version. That causes crashes at least on OS/2.

The patch adds it for Unix, Windows, and OS/2, not sure what I have to do about Mac or even what filename it has there.
Attachment #252220 - Flags: superreview?(neil)
Attachment #252220 - Flags: review?(kairo)
Comment on attachment 252220 [details] [diff] [review]
Add DOMI library to list of files to remove

r=me
Attachment #252220 - Flags: review?(kairo) → review+
Attachment #252220 - Flags: superreview?(neil) → superreview+
Could someone please check this in? I am supposed to restrict myself to OS/2-only stuff...
Comment on attachment 252220 [details] [diff] [review]
Add DOMI library to list of files to remove

>Index: xpinstall/packager/windows/browser.jst
>+    deleteThisFile("Components", "inspector.dll");

Actually, with my new-found understanding of the windows installer (see bug 367657), I realize this should go into the previous section of browser.jst (before |if (!gGreLocal)|).  With this patch, inspector.dll would not be deleted since the installer is now local by default.

I'll commit with this fixup later tonight, unless someone beats me to it.
Comment on attachment 252220 [details] [diff] [review]
Add DOMI library to list of files to remove

landed on trunk (I also moved the unix/os2 lines up with the other libs)
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
bug 325100 landed on the branch, so we need this on the branch too.
Attachment #252220 - Attachment is obsolete: true
Attachment #252967 - Flags: approval-seamonkey1.1.1?
Comment on attachment 252967 [details] [diff] [review]
what I checked in, merged to 1.8 branch

first-a=me for 1.1.1, still one needed to go
Comment on attachment 252967 [details] [diff] [review]
what I checked in, merged to 1.8 branch

a=me for 1.1.1
Attachment #252967 - Flags: approval-seamonkey1.1.1? → approval-seamonkey1.1.1+
Component: Installer: XPI Packages → Installer
QA Contact: general
You need to log in before you can comment on or make changes to this bug.