367719 - xf:input for xul can't be readonly

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[alexander :surkov (:asurkov)]

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 2

[aaronr]

Comment on attachment 252314 [details] [diff] [review]
patch

from what I see in the code, the xhtml input sets the 'readonly' attribute directly on the xf:input, not on the underlying control.  And it either sets the readonly attribute to the value 'readonly' or removes the attribute.

The xhtml way sounds more correct to me, but either way, we need to be more consistent between the xhtml and xul implementation, I'd think.

Comment 3

[alexander :surkov (:asurkov)]

(In reply to comment #2)
> (From update of attachment 252314 [details] [diff] [review])
> from what I see in the code, the xhtml input sets the 'readonly' attribute
> directly on the xf:input, not on the underlying control.

We don't set 'readonly' for xf:input, we set it on html:input.

>  And it either sets
> the readonly attribute to the value 'readonly' or removes the attribute.

For XUL I set 'readonly' attribute for xul:textbox. XUL specifity is readonly attribute value has boolean type, i.e. 'readonly' value doesn't work properly.

> The xhtml way sounds more correct to me

That's interesting, please give more details :)

Comment 4

[aaronr]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 252314 [details] [diff] [review] [details])
> > from what I see in the code, the xhtml input sets the 'readonly' attribute
> > directly on the xf:input, not on the underlying control.
> 
> We don't set 'readonly' for xf:input, we set it on html:input.

You are right, of course.  Reading this cryptic JS hurts my head! r=me

Comment 5

[alexander :surkov (:asurkov)]

needs to be checked in

Comment 6

[aaronr]

Attachment: testcase

Comment 7

[alexander :surkov (:asurkov)]

checked in trunk by aaron

Comment 8

[aaronr]

checked into 1.8 branch on 2007-04-12
checked into 1.8.0 branch on 2007-04-16