The default bug view has changed. See this FAQ.

xf:input for xul can't be readonly

RESOLVED FIXED

Status

Core Graveyard
XForms
RESOLVED FIXED
10 years ago
9 months ago

People

(Reporter: surkov, Assigned: surkov)

Tracking

({fixed1.8.0.12, fixed1.8.1.4})

Trunk
fixed1.8.0.12, fixed1.8.1.4

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

1017 bytes, patch
aaronr
: review+
smaug
: review+
Details | Diff | Splinter Review
1.63 KB, application/vnd.mozilla.xul+xml
Details
(Assignee)

Description

10 years ago
 
(Assignee)

Comment 1

10 years ago
Created attachment 252314 [details] [diff] [review]
patch
Attachment #252314 - Flags: review?(aaronr)
(Assignee)

Updated

10 years ago
Attachment #252314 - Flags: review?(Olli.Pettay)
(Assignee)

Updated

10 years ago
Status: NEW → ASSIGNED
Attachment #252314 - Flags: review?(Olli.Pettay) → review+

Comment 2

10 years ago
Comment on attachment 252314 [details] [diff] [review]
patch

from what I see in the code, the xhtml input sets the 'readonly' attribute directly on the xf:input, not on the underlying control.  And it either sets the readonly attribute to the value 'readonly' or removes the attribute.

The xhtml way sounds more correct to me, but either way, we need to be more consistent between the xhtml and xul implementation, I'd think.
Attachment #252314 - Flags: review?(aaronr) → review-
(Assignee)

Comment 3

10 years ago
(In reply to comment #2)
> (From update of attachment 252314 [details] [diff] [review])
> from what I see in the code, the xhtml input sets the 'readonly' attribute
> directly on the xf:input, not on the underlying control.

We don't set 'readonly' for xf:input, we set it on html:input.

>  And it either sets
> the readonly attribute to the value 'readonly' or removes the attribute.

For XUL I set 'readonly' attribute for xul:textbox. XUL specifity is readonly attribute value has boolean type, i.e. 'readonly' value doesn't work properly.

> The xhtml way sounds more correct to me

That's interesting, please give more details :)
(Assignee)

Updated

10 years ago
Blocks: 367826

Comment 4

10 years ago
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 252314 [details] [diff] [review] [details])
> > from what I see in the code, the xhtml input sets the 'readonly' attribute
> > directly on the xf:input, not on the underlying control.
> 
> We don't set 'readonly' for xf:input, we set it on html:input.

You are right, of course.  Reading this cryptic JS hurts my head! r=me

Updated

10 years ago
Attachment #252314 - Flags: review- → review+
(Assignee)

Comment 5

10 years ago
needs to be checked in

Comment 6

10 years ago
Created attachment 252677 [details]
testcase
(Assignee)

Comment 7

10 years ago
checked in trunk by aaron
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch

Comment 8

10 years ago
checked into 1.8 branch on 2007-04-12
checked into 1.8.0 branch on 2007-04-16
Keywords: fixed1.8.0.12, fixed1.8.1.4
Whiteboard: xf-to-branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.