367781 - adoptNode should update mMutationBits of the possible |window| object.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

adoptNode should update mMutationBits of the possible |window| object,
so that mutation event listeners work also in the new document.

I'll confirm this once I've written a testcase.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: possible patch

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 252388 [details] [diff] [review]
possible patch

oops, wrong file :)

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: This is the testcase!

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Peterv, any opinion whether we should set the exact mutation bits to
window, or is it enough to set all.
Mutation bits are anyway just a way to optimize mutation event
dispatching.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Copy only necessary mutation bits

Comment 6

[Peter Van der Beken [:peterv]]

Comment on attachment 252896 [details] [diff] [review]
Copy only necessary mutation bits

>Index: content/events/src/nsEventListenerManager.cpp
>===================================================================

>+PRUint32
>+nsEventListenerManager::MutationListenerBits()

>+    PRInt32 count = mListeners.Count();
>+    for (PRInt32 i = 0; i < count; ++i) {

Declare the i next to count.

>Index: content/events/src/nsEventListenerManager.h
>===================================================================

>+  virtual PRUint32 MutationListenerBits();

Does this need to be virtual?

>+  static PRUint32 MutationBitForEventType(PRUint32 aEventType);

I'd just make this a static function in the cpp file.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

> >Index: content/events/src/nsEventListenerManager.h
> >===================================================================
> 
> >+  virtual PRUint32 MutationListenerBits();
> 
> Does this need to be virtual?

yes, because it is the implementation for 
nsIEventListenerManager::MutationListenerBits().
So it is anyway virtual..,

Comment 8

[Peter Van der Beken [:peterv]]

Right, I should get some sleep ;-).

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Attachment: checked in

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Attachment: mochitest

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 253610 [details] [diff] [review]
mochitest

And will add that missing newline to the end of Makefile.in