367806 - Remove blur code in tabbrowser.xml

Status: RESOLVED WORKSFORME

(Firefox :: Tabbed Browser, defect)

Description

[Martijn Wargers (dead)]

I had an irc chat with Aaron on this. Basically he agreed that we should try to
remove this code, but he suggested to me that I should file a new bug on that,
and put the accompanying patch for the removal in there.
If it comes out that something breaks, then the code should be put back in, but then at least it is known in what situation this code was necessary.

This is the new bug, a follow-up on bug 363934.

Comment 1

[Martijn Wargers (dead)]

Attachment: patch

Sorry, I let this one slip, and in the meanwhile some other code was added (by bug 323805).
But it still should be possible to safely remove this.

Comment 2

[[e-mail]]

(In reply to comment #0)
>If it comes out that something breaks, then the code should be put back in, but
>then at least it is known in what situation this code was necessary.
Steps to reproduce problem:
1. Load a page with a link in it, and tab to that link
2. Press Ctrl+T
3. Press Tab (to focus the tab itself)
4. Press Up
Note that although the tab actually has focus, the link still appears outlined.
Also at this point try pressing Tab a few times ;-)

Comment 3

[[e-mail]]

Comment on attachment 275267 [details] [diff] [review]
patch

By the way suite's tabbrowser.xml now lives in mozilla/suite/browser

Comment 4

[Martijn Wargers (dead)]

Attachment: testcase

Thanks Neil.
So apparently that code in tabbrowser.xml is used to work around a deeper bug in Mozilla where window.focus() doesn't unpaint the outline of the previously focused node (and blur get fired 2 times for some odd reason).

Comment 5

[Neil Deakin]

Is this bug still relevant?

Comment 6

[Martijn Wargers (dead)]

I guess not, the relevant code doesn't seem to be there, after a quick glanse.