File->Save should use nsIFilePicker instead of nsFileSpecWithUI

VERIFIED FIXED in M18

Status

SeaMonkey
UI Design
P3
normal
VERIFIED FIXED
18 years ago
14 years ago

People

(Reporter: Stuart Parmenter, Assigned: Bill Law)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [nsbeta2+])

Attachments

(1 attachment)

(Reporter)

Description

18 years ago
File->Save should use nsIFilePicker instead of nsFileSpecWithUI.  We need to get
rid of nsFileSpecWithUI ASAP.

Updated

18 years ago
Keywords: nsbeta2
Target Milestone: --- → M17

Comment 1

18 years ago
PDT needs to know the noticable impact to user.
Whiteboard: [NEED INFO]
(Reporter)

Comment 2

18 years ago
having multiple file pickers could confuse the user.  Behavior between the two
is slightly different on mac and windows, and very different on linux.  The old
one has numerous bugs which won't be fixed and the new one contains some
features that the old one does not.
Whiteboard: [NEED INFO]

Comment 3

18 years ago
Putting on [nsbeta2+] radar for beta2 fix. 
Whiteboard: [nsbeta2+]
(Assignee)

Comment 4

18 years ago
I thought I remembered reviewing a patch that did this but apparently I imagined 
it or it never got checked in.  I've coded this up and am awaiting review.
Status: NEW → ASSIGNED

Comment 5

18 years ago
Move to M18 target milestone.
Target Milestone: M17 → M18

Comment 6

18 years ago
Bill, I am getting an error when I compile your patch on Linux,

c++ -o nsStreamTransfer.o -c -DOSTYPE=\"Linux2.2\" -DOJI 
-I../../../../dist/include -I../../../../include     -I/usr/X11R6/include  
-fPIC  -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith
-Wbad-function-cast -Wcast-align -Woverloaded-virtual -Wsynth -Wshadow -pedantic
-Wno-long-long -pthread  -DDEBUG -DDEBUG_slamm -DTRACING -g -DMOZILLA_CLIENT
-include ../../../../config-defs.h -Wp,-MD,.deps/nsStreamTransfer.pp
nsStreamTransfer.cpp
nsStreamTransfer.cpp: In method `nsresult
nsStreamTransfer::SelectFileAndTransferLocation(class nsIChannel *, class
nsIDOMWindow *)':
nsStreamTransfer.cpp:98: conversion from `nsXPIDLCString' to non-scalar type
`nsCAutoString' requested
g

Updated

18 years ago
Blocks: 32014
I have a patch that fixes this bug and 32014 as well.
The patch I just attached, in addition to fixing this bug, adds a prefs API for 
Get/SetFilePref (which will replace the old one once everyone is converted).  It 
also fixes a filepicker bug I found with setting the initial directory.
(Assignee)

Comment 10

18 years ago
Brian, have you tested that on Mac by any chance?  nsIFilePicker isn't working 
there in certain cases (or so I've found).
(Assignee)

Comment 11

18 years ago
Fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
vrfy.
Status: RESOLVED → VERIFIED
Product: Core → Mozilla Application Suite
You need to log in before you can comment on or make changes to this bug.