36789 - File->Save should use nsIFilePicker instead of nsFileSpecWithUI

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P3)

Description

[Stuart Parmenter]

File->Save should use nsIFilePicker instead of nsFileSpecWithUI.  We need to get
rid of nsFileSpecWithUI ASAP.

Comment 1

[leger]

PDT needs to know the noticable impact to user.

Comment 2

[Stuart Parmenter]

having multiple file pickers could confuse the user.  Behavior between the two
is slightly different on mac and windows, and very different on linux.  The old
one has numerous bugs which won't be fixed and the new one contains some
features that the old one does not.

Comment 3

[leger]

Putting on [nsbeta2+] radar for beta2 fix. 

Comment 4

[Bill Law]

I thought I remembered reviewing a patch that did this but apparently I imagined 
it or it never got checked in.  I've coded this up and am awaiting review.

Comment 5

[don]

Move to M18 target milestone.

Comment 6

[Steve Lamm]

Bill, I am getting an error when I compile your patch on Linux,

c++ -o nsStreamTransfer.o -c -DOSTYPE=\"Linux2.2\" -DOJI 
-I../../../../dist/include -I../../../../include     -I/usr/X11R6/include  
-fPIC  -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith
-Wbad-function-cast -Wcast-align -Woverloaded-virtual -Wsynth -Wshadow -pedantic
-Wno-long-long -pthread  -DDEBUG -DDEBUG_slamm -DTRACING -g -DMOZILLA_CLIENT
-include ../../../../config-defs.h -Wp,-MD,.deps/nsStreamTransfer.pp
nsStreamTransfer.cpp
nsStreamTransfer.cpp: In method `nsresult
nsStreamTransfer::SelectFileAndTransferLocation(class nsIChannel *, class
nsIDOMWindow *)':
nsStreamTransfer.cpp:98: conversion from `nsXPIDLCString' to non-scalar type
`nsCAutoString' requested
g

Comment 7

[Brian Ryner (not reading)]

I have a patch that fixes this bug and 32014 as well.

Comment 8

[Brian Ryner (not reading)]

Attachment: Fix

Comment 9

[Brian Ryner (not reading)]

The patch I just attached, in addition to fixing this bug, adds a prefs API for 
Get/SetFilePref (which will replace the old one once everyone is converted).  It 
also fixes a filepicker bug I found with setting the initial directory.

Comment 10

[Bill Law]

Brian, have you tested that on Mac by any chance?  nsIFilePicker isn't working 
there in certain cases (or so I've found).

Comment 11

[Bill Law]

Fix checked in.

Comment 12

[sairuh (rarely reading bugmail)]

vrfy.