367903 - bugzilla url munger truncates bug ids of more than 6 digits

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Tom Elliott]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.9) Gecko/20061206 Firefox/1.5.0.9
Build Identifier: Chatzilla 0.9.77 [Firefox 1.5.0.9/2006120612]

assuming you change your bugzilla url to http://mybug.org?id=%s
then
bug 123456 
yields
http://mybug.org?id=123456
but 
bug 1234567 
yields
http://mybug.org?id=123456
this is a problem if your bug tracker is sourceforge, where many ticket ids are 7 digits. 

Reproducible: Always

Steps to Reproduce:
1.see above
2.
3.
Actual Results:  
fails to include full bug id in resulting link

Expected Results:  
bug ids of arbitrary length should be handled gracefully

Comment 1

[:Gijs (out for now; he/him)]

Attachment: Patch

This should fix it, I believe...

Comment 2

[:Gijs (out for now; he/him)]

Marking blocking the munger reorg bug, cause this bug will break the patch over there (which is actually already broken, but I'm planning on attaching an unbroken one soon, probably before this gets checked in and gets review. This way I won't forget (I hope).

Comment 3

[James Ross]

Comment on attachment 254023 [details] [diff] [review]
Patch

The limits on length are there for good reason. I wouldn't mind expanding the limit to 7 (or 8) digits, but I don't want the limits removed unless you can clearly show it is safe.

Comment 4

[James Ross]

Comment on attachment 254023 [details] [diff] [review]
Patch

Oh go on then, but we'll have to watch for issues.

Comment 5

[:Gijs (out for now; he/him)]

Checking in mozilla/extensions/irc/xul/content/static.js;
/cvsroot/mozilla/extensions/irc/xul/content/static.js,v  <--  static.js
new revision: 1.227; previous revision: 1.226
done
Checking in mozilla/extensions/irc/xul/lib/munger.js;
/cvsroot/mozilla/extensions/irc/xul/lib/munger.js,v  <--  munger.js
new revision: 1.23; previous revision: 1.22
done