bugzilla url munger truncates bug ids of more than 6 digits

RESOLVED FIXED

Status

Other Applications
ChatZilla
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Tom Elliott, Assigned: Gijs)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [cz-0.9.78])

Attachments

(1 attachment)

(Reporter)

Description

12 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.9) Gecko/20061206 Firefox/1.5.0.9
Build Identifier: Chatzilla 0.9.77 [Firefox 1.5.0.9/2006120612]

assuming you change your bugzilla url to http://mybug.org?id=%s
then
bug 123456 
yields
http://mybug.org?id=123456
but 
bug 1234567 
yields
http://mybug.org?id=123456
this is a problem if your bug tracker is sourceforge, where many ticket ids are 7 digits. 

Reproducible: Always

Steps to Reproduce:
1.see above
2.
3.
Actual Results:  
fails to include full bug id in resulting link

Expected Results:  
bug ids of arbitrary length should be handled gracefully
(Assignee)

Comment 1

12 years ago
Created attachment 254023 [details] [diff] [review]
Patch

This should fix it, I believe...
Assignee: rginda → gijskruitbosch+bugs
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #254023 - Flags: review?(silver)
(Assignee)

Comment 2

12 years ago
Marking blocking the munger reorg bug, cause this bug will break the patch over there (which is actually already broken, but I'm planning on attaching an unbroken one soon, probably before this gets checked in and gets review. This way I won't forget (I hope).
Blocks: 237538
OS: Windows XP → All
Hardware: PC → All
Version: unspecified → Trunk

Comment 3

12 years ago
Comment on attachment 254023 [details] [diff] [review]
Patch

The limits on length are there for good reason. I wouldn't mind expanding the limit to 7 (or 8) digits, but I don't want the limits removed unless you can clearly show it is safe.
Attachment #254023 - Flags: review?(silver) → review-

Comment 4

12 years ago
Comment on attachment 254023 [details] [diff] [review]
Patch

Oh go on then, but we'll have to watch for issues.
Attachment #254023 - Flags: review- → review+
(Assignee)

Comment 5

12 years ago
Checking in mozilla/extensions/irc/xul/content/static.js;
/cvsroot/mozilla/extensions/irc/xul/content/static.js,v  <--  static.js
new revision: 1.227; previous revision: 1.226
done
Checking in mozilla/extensions/irc/xul/lib/munger.js;
/cvsroot/mozilla/extensions/irc/xul/lib/munger.js,v  <--  munger.js
new revision: 1.23; previous revision: 1.22
done
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Updated

12 years ago
Whiteboard: [cz-0.9.78]
You need to log in before you can comment on or make changes to this bug.