36795 - Returning uninitialized variable

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect, P3)

Description

[jim_nance]

The following code is returning rv uninitialized:

nsresult
nsBookmarksService::getLocaleString(const char *key, nsString &str)
{
        PRUnichar       *keyUni = nsnull;
        nsAutoString    keyStr; keyStr.AssignWithConversion(key);
        nsresult        rv;
        if (mBundle && (NS_SUCCEEDED(rv = mBundle->GetStringFromName(keyStr.GetU
nicode(), &keyUni)))
                && (keyUni))
        {
                str = keyUni;
                nsCRT::free(keyUni);
        }
        else
        {
                str.Truncate();
        }
        return(rv);
}

Notice that if mBundle is 0, then rv is not set before it is
returned.  I would just fix this, but I dont know what it should
return in that case.  This code is at line 1978 of
xpfe/components/bookmarks/src/nsBookmarksService.cpp

Comment 1

[Steve Lamm]

-->rjc

Comment 2

[Robert John Churchill]

Fixed.

Comment 3

[Claudius Gayle]

code-level fix, markng VERIFIED