368020 - background-clip and background-origin broken on line/column/page-broken frames

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

background-clip and background-origin don't work correctly whereever border and padding are skipped because a frame is broken over lines, columns, or pages.  Patch, with testcases included, coming shortly.

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch

This is the current state of my patch (minus the image the tests need, which I should check in, which is just a copy of http://developer.mozilla.org/wiki-images/en/a/a6/Repeatable-diagonal-gradient-background.png ).

Tests 3 and 4 fail because -moz-background-inline-policy assumes border-box, rather than following either of background-origin or background-clip, which I think it should.

I haven't yet figured out why test 1 fails, but I think it's some sort of block pagination issue.

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch

Filed 2 bugs (bug 368079 and bug 368085) on the failing regression tests.

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I've also commented out test 2, which fails in reftest but not just testing in the browser, and filed bug 368157.  (Commented out rather than marked failing because I suspect the failure could be platform-specific.)

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Fix checked in to trunk.

Comment 5

[Jeff Walden [:Waldo]]

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=reftest.list&branch=&root=/cvsroot&subdir=mozilla/layout/reftests&command=DIFF_FRAMESET&rev1=1.30&rev2=1.31