368081 - font-size-adjust broken on windows if the text has non solid color

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: testcase

This is a remain work for bug 353872. I forgot to change the Fast function.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.0

Sturat, sorry for this silly bug.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.0

Oops, I attached the wrong file....

Comment 3

[Stuart Parmenter]

Comment on attachment 252638 [details] [diff] [review]
Patch rv1.0

+    const double cairoToPixels =
+                     cairofontfactor * currentFont->GetAdjustedSize();

please just put this on one line.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.0.1

Thanks, but the count of characters is over 80 if adding space around '*'. (it's just 80 characters in this patch.) Do you like which style?

Comment 5

[Stuart Parmenter]

We've generally been going to around 120 characters in thebes (or slightly longer if it makes the code more clear)

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to comment #5)
> We've generally been going to around 120 characters in thebes (or slightly
> longer if it makes the code more clear)
> 

O.K. Thanks. I'll add the space around the '*'.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.0.2

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

checked-in.