If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Status

()

Toolkit
XUL Widgets
RESOLVED WONTFIX
11 years ago
2 years ago

People

(Reporter: Neil Deakin, Assigned: Neil Deakin)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

11 years ago
This is about checking in the XUL widget test suite I've been working on. Currently, I'm going to put them in toolkit/tests and can run during the make check phase.

Comment 1

11 years ago
Nice. How do they run?
(Assignee)

Comment 2

11 years ago
It should run by opening a browser and running through the tests for each widget. It works in the same way as the reftests do.

It doesn't output any pass/fail state to the console though as I'm not sure what should happen there. It does display a table of green pass and red fail rows.

(Assignee)

Comment 3

11 years ago
Created attachment 253251 [details] [diff] [review]
Current tests I have written 

This adds tests to test the following widgets and xul features:
  datepicker, key, scale, stringbundle, textbox, spellchecking textbox,
  timepicker, notificationbox, menu, menu buttons, trees and templates

The patch in bug 364508 is needed for the tests to work. Some subtests don't work if the window isn't raised, and three of the spellchecking subtests don't work on Windows.

To run the tests:
  cd [outputdir]/toolkit/tests
  make lcheck
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
That patch doesn't include happy.png (naturally, since it's binary)...
So when I run these, it runs the "Menu Toolbar Button" tests what looks like partway (according to the progress meter) then stops...  Is that expected?

Also, given a test failure is there a reasonable way to view that test?

Finally, there are 0 tests for toolbar, images, etc?  Or am I doing something wrong?
(Assignee)

Comment 6

11 years ago
The patch here for the tests are works in progress, so only the elements listed in comment 3 have tests.

> So when I run these, it runs the "Menu Toolbar Button"
> tests what looks like partway (according to the progress meter)
> then stops...  Is that expected?

No, but that was an issue on Windows. It's possible I made the patch before I fixed that issue.
(Assignee)

Comment 7

11 years ago
Created attachment 256829 [details] [diff] [review]
This version includes updated tests and works with the event simulating api
Attachment #253251 - Attachment is obsolete: true
(Assignee)

Comment 8

2 years ago
These tests are old and mostly either have been added or have equivalents added.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.