Closed
Bug 368123
Opened 17 years ago
Closed 17 years ago
CanvasFrame::RemoveFrame and CanvasFrame::AppendFrames can return an uninitialized rv
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
People
(Reporter: dveditz, Assigned: dveditz)
References
Details
Attachments
(1 file)
1.42 KB,
patch
|
dbaron
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
Depending on the path taken, CanvasFrame::RemoveFrame and CanvasFrame::AppendFrames in nsHTMLFrame.cpp can return an uninitialized 'rv' value. This is a whitespace diff for clarity, I'm also pushing the FrameNeedsReflow lines over to preserve the existing alignment.
Attachment #252689 -
Flags: superreview?(dbaron)
Attachment #252689 -
Flags: review?(dbaron)
Comment on attachment 252689 [details] [diff] [review] return valid 'rv' r+sr=dbaron. Thanks for fixing this.
Attachment #252689 -
Flags: superreview?(dbaron)
Attachment #252689 -
Flags: superreview+
Attachment #252689 -
Flags: review?(dbaron)
Attachment #252689 -
Flags: review+
Blocks: reflow-refactor
Assignee: dveditz → nobody
Component: Layout: HTML Frames → Layout: Misc Code
QA Contact: layout.html-frames → layout.misc-code
Stupid bugzilla automatically reassigning when I change component...
Assignee: nobody → dveditz
Updated•17 years ago
|
Summary: uninitialized rv in Remove and Append CanvasFrame in nsHTMLFrame can re → CanvasFrame::RemoveFrame and CanvasFrame::AppendFrames can return an uninitialized rv
Assignee | ||
Updated•17 years ago
|
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 3•17 years ago
|
||
Checking in nsHTMLFrame.cpp; /cvsroot/mozilla/layout/generic/nsHTMLFrame.cpp,v <-- nsHTMLFrame.cpp new revision: 1.170; previous revision: 1.169
Updated•17 years ago
|
Flags: in-testsuite?
Updated•6 years ago
|
Product: Core → Core Graveyard
Updated•6 years ago
|
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•