368357 - need to canonicalize numeric ipv4 encoded as ipv6

Status: REOPENED

(Toolkit :: Safe Browsing, defect, P3)

Description

[Tony Chang (Google)]

It looks like we properly handle http://[a.b.c.d]/ (we get a.b.c.d), but we don't seem to handle http://[::ffff:a.b.c.d]/ or http://[0:0:0:0:0:ffff:a.b.c.d]/ .

Comment 1

[maria.neise1]

Hey,
I started working on this bug and have a possible solution. I am new to Mozilla and the Firefox Project. I would appreciate it a lot if someone would help me and review my solution.
Thank you in advance.
Cheers,
Maria

Comment 2

[Josh Matthews [:jdm]]

That's great, Maria! The best way to get feedback on actual code changes is to make a diff and attach it to this bug (see 'Add an attachment' above). See https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_diff_and_patch_files.3f for more details, or feel free to ask for help in #introduction on irc.mozilla.org or send me an email.

Comment 3

[maria.neise1]

Attachment: Attempt to fix Bug 368357

Hey,
I attached the code of my first solution to fix the Bug 368357. I inserted a method into nsDefaultURIFixup.cpp that checks, whether the host has the correct prefix to make an IPv4 address out of it.
I would appreciate if someone would have a look at it and give me some feedback and tell me what else I have to take care of. I am not sure, whether I chose the right class for my solution.
Thanks a lot in advance.
Cheers,
Maria

Comment 4

[maria.neise1]

Hey,
I am still working on this bug.
RFC 4291 (http://tools.ietf.org/html/rfc4291#section-2.5.5) specifies the examples in the bug report (http://[::ffff:a.b.c.d]/ and http://[0:0:0:0:ffff:a.b.c.d]/) as IPv4 mapped IPv6 addresses. An IPv4 mapped IPv6 address marks an IPv4 only node. So I was wondering what the different scenarios would be if the application is on an IPv4 only node and Firefox either on an IPv4 only, IPv6 only or IPv4/IPv6 node.
IPv4 only: We get an IPv4 address from the DNS server, because both nodes are IPv4.
IPv6: We get the IPv4 mapped IPv6 address from the DNS server. We send IPv6 packets that will be translated to IPv4 packets by a translator.
IPv4/IPv6: We get either the IPv4 address or the IPv4 mapped IPv6 address and send IPv4 or IPv6 packets.
So I am not quite sure where the bug is.
I am really sorry for bothering you again. I would appreciate if someone could give me a hint.
Cheers,
Maria

Comment 5

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.