368622 - ::before { display: inline-block; } behaves like display: block;

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect, P3)

Description

[Henri Sivonen (:hsivonen)]

Build ID:
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a2pre) Gecko/20070129 Minefield/3.0a2pre

Steps to reproduce:
1) Load http://hsivonen.iki.fi/test/before-inline-block.html

Expected results:
Expected the number 1 to be on the same line as Foo and 2 on the same line as Bar.

Actual results:
The numbers occupy lines of their own.

Comment 1

[j.j.]

Attachment: simple testcase

I see this with winXP
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a2pre) Gecko/20070129 Minefield/3.0a2pre

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: partial patch

I'd expect this to work, but the 'width:3em;' doesn't, and I also get some assertions in nsLayoutUtils::ComputeWidthDependentValue.

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: reporter's testcase

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

So nsCSSFrameConstructor::CreateGeneratedContentFrame needs to call ConstructFrameByDisplayType, although I'm not sure whether that alone makes the necessary anonymous table objects (inside and outside)...

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch

This takes the simple approach; I think attacking allowing arbitrary 'display', 'position', 'float', and 'overflow' for generated content needs to wait for a redesign of frame construction.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 253677 [details] [diff] [review]
patch

Looks fine, but shouldn't you pass the SPACE_MGR and MARGIN_ROOT flags in the inline-block case?

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Checked in to trunk, with the flag-setting.

Comment 8

[Jeff Walden [:Waldo]]

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=reftest.list&branch=&root=/cvsroot&subdir=mozilla/layout/reftests&command=DIFF_FRAMESET&rev1=1.36&rev2=1.37