368799 - Refactor gfxPangoFont/gfxPangoFontGroup/gfxPangoTextRun

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

As discussed on IRC, we want to make gfxTextRun all cross-platform code based on gfxPangoTextRun's glyph storage, moving the platform-dependent glyph conversion, measurement and drawing code to gfxFont and gfxFontGroup implementations. This will greatly simplify the per-platform work required and also allow us to make the gfxTextRun interface more efficient.

The first, largest step is to make this separation happen in the gfxPango code. That is what this bug is about.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: patch

Moves all the platform-dependent code out of gfxPangoTextRun, to gfxPangoFont and gfxPangoFontGroup.

Hoisting this code up to gfxTextRun should be easy after this, requiring only changes in the names of types (gfxPangoFont -> gfxFont, gfxPangoTextRun -> gfxTextRun, gfxPangoFontGroup -> gfxFontGroup) and moving members up to those base classes. But we'll have to implement Mac and Windows support at the same time since the wrapper implementations won't work anymore.

This removes a few APIs that shouldn't be part of gfxTextRun: Measure/Draw/GetAdvanceWidthSpecialString (will be replaced by a simple cache of textruns in gfxFontGroup), FlushSpacingCache (not needed, spacing is never cached), and GetDecorationMetrics (callers should use fontGroup->GetFontAt(0)->GetMetrics()). I didn't want to waste time refactoring these, so I just removed them now. This will break building nsTextFrameThebes, I'll patch that up on my own (Not Part Of The Build).

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: real patch

Naturally, I attached the wrong patch.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Windows build bustage fix

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Mac build bustage fix

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: Flag 8-bit ATSUI text too