368839 - Explicitly set all Camino-specific prefs in all-camino.js

Status: RESOLVED FIXED

(Camino Graveyard :: Preferences, defect)

Description

[froodian (Ian Leue)]

Currently, we have a bunch of Camino-specific prefs which aren't listed in all-camino.js, since they default to "false", and it doesn't make a difference behaviorally.  These should stated explicitly in all-camino.js, for the following reasons:

1) It's good to document prefs, so we don't forget about them some day, rather than just adding them willy-nilly in code
2) The name "all-camino" implies that it's all the prefs
3) If people want to set these prefs they must do it through user.js, since the entries don't appear in about:config

We talked about this on IRC at some point, so filing NEW.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

camino.disable_bonjour - [false]
camino.viewsource_in_tab - [false]

Note that there are two more that exist to override our auto-accept-lang and auto-locale detection, so we can't put them in all-camino or they'll break things by overriding our detection every time.  I think we talked about putting them in as comments so that they're found, though:

camino.accept_languages - [ordered string]
camino.useragent.locale - [ab-CD]

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

camino.enable_ad_blocking - false

Apparently I mis-audited these; toggling that pref to false in about:config still shows it in bold (i.e., user-added).

I guess what we need to do is just compare the prefs in my list http://wiki.caminobrowser.org/User:Sardisson/Camino_Prefs to http://mxr.mozilla.org/mozilla/source/camino/resources/application/all-camino.js and make sure all are listed.

Comment 3

[Stuart Morgan]

Since I can't log into the wiki at the moment (due to user error) here's the results of a quick grep across every pref we check in Camino code (at least though the Cocoa pref accessors). Obviously, not all are relevant, but it's a reference point.

browser.backspace_action
browser.chrome.favicons
browser.download.autoDispatch
browser.download.progressDnldDialog.bringToFront
browser.download.progressDnldDialog.keepAlive
browser.history_expire_days
browser.link.open_newwindow
browser.link.open_newwindow.restriction
browser.sessionstore.resume_from_crash
browser.startup.homepage
browser.startup_page_override.version
browser.tabs.loadInBackground
browser.tabs.opentabfor.middleclick
browser.tabs.startPage
camino.accept_languages
camino.check_default_browser
camino.disable_bonjour
camino.enable_ad_blocking
camino.enable_flashblock
camino.enable_plugins
camino.enable_tabjumpback
camino.remember_window_state
camino.use_system_proxy_settings
camino.viewsource_in_tab
camino.warn_before_opening_feed
camino.warn_when_closing
capability.policy.default.Window.defaultStatus
chimera.log_js_to_console
chimera.search_page
general.useragent.vendorSub
intl.charset.detector
javascript.enabled
keyword.enabled
wallet.crypto.autocompleteoverride

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: trunk patch

This does the lifting.  With the exception of the language/locale override prefs (which we can't set, but are mentioned in comments) and a few prefs that we inherit from all.js, this gets everything on my list and Stuart's.

I moved around some of the download- and window/tab-related prefs to group them; I also zapped a few excess spaces (branch had a few more of them to zap) and clarified a few comments.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: branch version

Same as above, but branch doesn't have the CM pref, has a different version number, and has a few extra extraneous spaces that needed zapping, so separate patch.

Comment 6

[Chris Lawson (gone)]

Comment on attachment 270446 [details] [diff] [review]
trunk patch

r=me

Comment 7

[Chris Lawson (gone)]

Comment on attachment 270447 [details] [diff] [review]
branch version

r=me

Comment 8

[Stuart Morgan]

Landed on trunk and MOZILLA_1_8_BRANCH