368865 - REG_APP_DESC should be removed from the Calendar 1.8 branch

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[u162289]

Attachment: Patch removing the string

As discussed with ssitter on IRC, this string is currently only used in Firefox trunk :

http://lxr.mozilla.org/mozilla/search?string=REG_APP_DESC
http://lxr.mozilla.org/mozilla1.8/search?string=REG_APP_DESC

So it could be removed (plus, the string is about browsing and not calendaring)

Comment 1

[Michiel van Leeuwen (email: mvl+moz@)]

We are keeping trunk and branch synchronized. If this string is to be removed, it should also be removed on trunk. If the string is needed on trunk (or very likely to be needed soon), it has to stay on branch too.

Comment 2

[Stefan Sitter [:ssitter]]

(In reply to comment #1)

REG_APP_DESC doesn't exist on Trunk.

Robert, you added REG_APP_DESC to /calendar/locales/en-US/installer/custom.properties with Bug 349551. But it's not used as far as I can see. Is there a reason not to remove it?

Comment 3

[Robert Strong (they/them - no direct email)]

This string is needed for Vista OS Integration so please don't remove it

Comment 4

[u162289]

Ok,
So we have to reword it for Sunbird. As I'm not a native English speaker, I will let somebody else do it

Comment 5

[Stefan Sitter [:ssitter]]

(In reply to comment #3)
> This string is needed for Vista OS Integration so please don't remove it

Robert, is there a bug for this? Currently the string only exists on MOZILLA_1_8_BRANCH but not on Trunk, is not used and states that Sunbird is a web browser.

Comment 6

[Robert Strong (they/them - no direct email)]

I don't recall... I believe I brought this up face to face in the office before 2.0. I don't recall if it was to danm or lilmatt

Comment 7

[Stefan Sitter [:ssitter]]

We either should
- remove the string from MOZILLA_1_8_BRANCH after the 0.7 release and add it back once it's needed
or
- reword the string from "Sunbird delivers safe, easy web browsing. [...] let you get the most out of the web." to somthing useful and add it to Trunk too.

Comment 8

[Martin Schröder [:mschroeder]]

(In reply to comment #7)
> - reword the string from "Sunbird delivers safe, easy web browsing. [...] let
> you get the most out of the web." to somthing useful and add it to Trunk too.

I think, this is the way we should go.

Comment 9

[Stefan Sitter [:ssitter]]

Comment on attachment 253499 [details] [diff] [review]
Patch removing the string

In my opinion we should remove the string now to keep Trunk and 1.8 branch in sync. Once we need it we can add it back with a suitable description for Sunbird. This way the l10n teams also get notified about the string change. This might not be the case if we just reword the description now.

Comment 10

[Simon Paquet [:sipaq]]

Comment on attachment 253499 [details] [diff] [review]
Patch removing the string

I don't think removing this string is the right way to go. IMO we should add it on the 1.8 branch as well, reword it properly on the trunk and post to mozilla.dev.l10n about this. Filing followup bugs for the different locales would also be a good idea.

Minusing for now, but I may retract this, if you can convince me that this patch is still a good idea.

Comment 11

[Stefan Sitter [:ssitter]]

The string 1) only exists on the 1.8 branch, 2) is totally wrong in it's content and 3) is nowhere used in the calendar code. Removing the string would save all the extra work mentioned in Comment #10 unless the string might be actually required sometime in the future. But I don't really care anymore. Either take the fix or resolve this bug as wontfix.

Comment 12

[Stefan Sitter [:ssitter]]

As there is no agreement on removing the unused string does somebody has a proposal for the rewording? The string should describe Sunbird in a few short sentences.

Comment 13

[Simon Paquet [:sipaq]]

Comment on attachment 253499 [details] [diff] [review]
Patch removing the string

After thinking more about this, I now think that the patch is the right way to go.

r=sipaq

Comment 14

[Simon Paquet [:sipaq]]

Since this just removes a string and gives us full string parity with the trunk, I think it is okay to check this in now and add the late-l10n keyword.

Comment 15

[Simon Paquet [:sipaq]]

Patch checked in.