Closed
Bug 368910
Opened 18 years ago
Closed 18 years ago
Yet Another Cleanup Thebes APIs Bug
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
People
(Reporter: pavlov, Assigned: pavlov)
Details
Attachments
(1 file)
68.01 KB,
patch
|
vlad
:
review+
|
Details | Diff | Splinter Review |
need to make our use of gfxRect/gfxPoint/gfxSize consistent. I've been told passing by const ref is faster than by value so I'm changing our methods that use those structs to be passed by const ref. Change things to use structs instead of seperate width/height params, etc.
Also moving the printing functions off of gfxContext since they're really surface specific so you call the already existing ones on gfxASurface.
Assignee | ||
Comment 1•18 years ago
|
||
this also makes all surface constructors take arguments in the same order. the order is: <native stuff>, <size>, <format>
Attachment #253548 -
Flags: review?(vladimir)
Comment on attachment 253548 [details] [diff] [review]
patch
> gfxQuartzSurface(CGContextRef context, const gfxSize& size, PRBool y_grows_down);
y_grows_down should come before size, to be consistent.. since it's really part of the "native thing".
Other than that, yeah, sure.
Attachment #253548 -
Flags: review?(vladimir) → review+
Assignee | ||
Updated•18 years ago
|
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•