368921 - All events in ICS file are not upgraded to new timezones

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Matthew (lilmatt) Willis]

Attachment: Make Assign(char* c) convert

When opening an ICS file and changing one event, the other events are not upgraded to the new 20070129_1 timezones.

STR in Sunbird:
1. File -> Open an ICS file with 20050126_1 timezones and multiple events.
2. Edit one event's title
3. Export the calendar
4. Note that only the edited event's timezone has been updated to 20070129_1

Expected:
All events in the file are updated to the 20070129_1 timezone, and the 20050126_1 timezone is removed from the file.


This happens because we erroneously assumed that calTzId::Assign(char* c) was only called for "utc" and "floating" timezones, and therefore we didn't attempt conversion on it.  In actuality, we _do_ pass regular tzIds to it, and so it needs to also convert.

Rather than duplicate the code, we'll just call the other Assign function with c cast to a string.

Comment 1

[Matthew (lilmatt) Willis]

Credit to Stefan Sitter for originally finding this.

Comment 2

[OOO until Jun 29 - Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 253561 [details] [diff] [review]
Make Assign(char* c) convert

r1/r2=dmose; nice find!

Comment 3

[Matthew (lilmatt) Willis]

Patch checked in on:
  SUNBIRD_0_3_BRANCH
  LIGHTNING_0_3_BRANCH
  MOZILLA_1_8_BRANCH
  trunk

-> FIXED

Comment 4

[cmtalbert]

VERIFIED on 0.3.1: Lightning: 2007020304 Thunderbird: version 2 beta 2 (20070202).

Comment 5

[cmtalbert]

Sorry for the spam, hit commit too soon.  Also verified on 0.3.1 Sunbird: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20070203 Sunbird/0.3.1

Needs verifiying on Mozilla_1_8_branch