368933 - [cairo-cocoa] Printing any page produces blank output

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

STR:

1. Grab a trunk build (I used Cm 2007-01-31-01 and Cm 2007-01-31-15)
2. Visit any page, say www.google.com
3. Print (or Save as PDF in the print dialogue)
4. Marvel at the speed at which we print since "use Print Manager stuff" landed
5. Wonder why the paper is blank

My wild guess is that this began after print manager stuff landed, but I haven't had a chance to go digging for a regression range.  I've also been told we've heard some complaints via Camino feedback and the Camino forum about this recently.  (10.3.9 here, for reference.)

Comment 1

[philippe (part-time)]

The Print-to-PDF issue is already mentioned in bug 368400.

I finally had the opportunity to try to print to paper: using a heavy duty Epson Fiery PS office printer. I don't even get a blank page. The printer spits out an error message on its little screen, something about 'empty file'. The file sent to the print server was 8k (about correct for the test file I was using).

I'm pretty sure those are all 'regressions' since bug 367433. 'regressions' because printing didn't work before, on trunk.

Comment 2

[Colin Barrett [:cbarrett]]

Are you both using 10.3.9? This may be a 10.3.9 issue. I will see if I can get access to 10.3.9 machine for further testing.

Comment 3

[philippe (part-time)]

(In reply to comment #2)
> Are you both using 10.3.9? This may be a 10.3.9 issue. I will see if I can get
> access to 10.3.9 machine for further testing.
> 
No, I'm using 10.4.8.

Comment 4

[Colin Barrett [:cbarrett]]

Can you confirm this in Firefox? 'cause it's all working for me. I have not tested a Camino nightly.

Comment 5

[philippe (part-time)]

I tested both Camino trunk and when that one failed, Minefield. Both gave the same result.

I remember testing your patch (bug 367433 comment #12), and it worked nicely. But after the whole thing landed, nothing any more: Preview, Print-to-PDF, print to paper, all return a blank page.

Comment 6

[philippe (part-time)]

Additional note: I'm using 10.4.8 on PowerPc machines, this may (or not) matter.

Comment 7

[Colin Barrett [:cbarrett]]

Since Smokey is using 10.3.9, he is using PPC. That may be the issue here.

Unfortunately, bugzilla has no way to indicate that.

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: console spew from printing in a debug build

Since my full tree now has recent Gecko changes, I thought I'd print and see if the console logged anything useful.  I'm not sure it did, but here it is ;)  It's annotated for pageload, Cmd-P, and hitting return in the print dialogue.

Comment 10

[Colin Barrett [:cbarrett]]

I've been poking at this for a while, I might as well take the bug.

Comment 11

[J. Novinger]

Same problem. When you try to print from Thunderbird [version 3 alpha 1 (20070301)] - Nothing but blank pages (Mac OS X 10.4.8)

Comment 12

[Stuart Parmenter]

colin you had a partial patch for this right?

Comment 13

[Colin Barrett [:cbarrett]]

Yeah. It's a bit of a hack to avoid some null getting passed around. Should probably figure out exactly what's going on there, maybe even write it down somewhere, too. Anyway, I'll put the patch up shortly.

Comment 14

[Josh Aas]

I can't print anything on Intel or PPC - just blank pages.

Comment 15

[Josh Aas]

Attachment: fix v1.0

This patch is really from Stuart Parmenter.

Comment 16

[philippe (part-time)]

(In reply to comment #15)
> Created an attachment (id=259756) [details]
> fix v1.0
> 
With this patch applied, I crash when hitting the Preview, Print or Print-to-PDF button.
Camino build, 10.4.9 PPC.

Print-to-pdf generates a blank 8kb file that can't be opened by Preview.app.

0   org.mozilla.camino             	0x007f9f64 nsThebesDeviceContext::Shutdown() + 568
1   org.mozilla.camino             	0x00328100 nsSimplePageSequenceFrame::GetEdgePaperMargin(nsMargin&) + 736
2   org.mozilla.camino             	0x00543108 nsPrintEngine::PrintPage(nsPrintObject*, int&) + 644
3   org.mozilla.camino             	0x005475a0 nsPagePrintTimer::Start(nsPrintObject*) + 64
4   libxpcom_core.dylib            	0x2c0502e8 nsTimerImpl::Fire() + 220
5   libxpcom_core.dylib            	0x2c050624 nsTimerImpl::InitCommon(unsigned, unsigned) + 512
6   libxpcom_core.dylib            	0x2c04d2d4 nsThread::nsChainedEventQueue::PutEvent(nsIRunnable*) + 1516
7   libxpcom_core.dylib            	0x2c00adb0 NS_ProcessPendingEvents_P(nsIThread*, unsigned) + 92
8   org.mozilla.camino             	0x007a3260 nsBaseAppShell::NativeEventCallback() + 84
9   org.mozilla.camino             	0x00794db0 nsAppShell::ProcessGeckoEvents() + 228
10  org.mozilla.camino             	0x00794e8c nsAppShell::ProcessGeckoEvents() + 448
11  com.apple.Foundation           	0x92bd9924 __NSFireMachPort + 276
12  com.apple.CoreFoundation       	0x907ec850 __CFMachPortPerform + 176
13  com.apple.CoreFoundation       	0x907ec764 __CFRunLoopDoSource1 + 152
14  com.apple.CoreFoundation       	0x907dee7c __CFRunLoopRun + 1556

Comment 17

[Josh Aas]

Yeah, I get crashes too but I think they are a different bug. There is a patch floating around that fixes the crash, it worked for me. Colin is filing a bug on the crash soon.

Comment 18

[Josh Aas]

The patch I'm talking about is on bug 375495.

philippe - does the patch on 375495 fix your crash?

Comment 19

[philippe (part-time)]

(In reply to comment #18)
> The patch I'm talking about is on bug 375495.
> 
> philippe - does the patch on 375495 fix your crash?
> 

Yes. No crashes anymore with either 'Preview', 'Print' and 'Print-to-PDF'
And no more blank output (although I didn't try to print to paper, printer is turned of).

Yay.

Comment 20

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

A couple of notes:

1) We don't display the "processing" dialogue (entitled "Print") after hitting the "Print" button in the sheet, so there's not a visual cue that we did successfully print (I can't remember if that's ever worked post-cocoa-cairo-printing; I'll check later and file a separate bug if not).

2) Printing is excruciatingly slow again; I hope that's all debug-build slowness and will check with an official nightly once this is in.

3) There are other issues covered by other bugs, so I'll comment on them those places.

Comment 21

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #20)
> 1) We don't display the "processing" dialogue (entitled "Print") after hitting
> the "Print" button in the sheet, so there's not a visual cue that we did
> successfully print (I can't remember if that's ever worked
> post-cocoa-cairo-printing; I'll check later and file a separate bug if not).

Now bug 375572.

Comment 22

[Colin Barrett [:cbarrett]]

bug 375495 has an updated patch, it should work!

Comment 23

[Josh Aas]

fixed on trunk