369004 - bootstrap cleanup and style fixes

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Robert Helmer [:rhelmer]]

* remove quotes from hash keys
* die is a function; use parens
* normalize alignment
* don't make $config global anywhere, it's implemented as a singleton
* remove or correct incorrect comments

Comment 1

[Robert Helmer [:rhelmer]]

Attachment: cleanup patch

Comment 2

[J. Paul Reed [:preed]]

I think we got confused on the quoting convention.

Hash keys that aren't variables *should* have quotes, so:

$foo{'bar'}
$foo{$bar}

but NOT $foo{bar}.

There's one exception: the args style passing; so,

MyFunction(foo => 'bar', foo2 => $barTwo)

Comment 3

[Robert Helmer [:rhelmer]]

Attachment: do not remove quotes from hash keys

Yeah I see your point, it's easier to read if these are obviously strings.

Comment 4

[J. Paul Reed [:preed]]

Comment on attachment 254339 [details] [diff] [review]
do not remove quotes from hash keys

Looks good; r=preed.