bootstrap cleanup and style fixes

RESOLVED FIXED

Status

defect
RESOLVED FIXED
13 years ago
6 years ago

People

(Reporter: rhelmer, Assigned: rhelmer)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

* remove quotes from hash keys
* die is a function; use parens
* normalize alignment
* don't make $config global anywhere, it's implemented as a singleton
* remove or correct incorrect comments
Assignee: build → rhelmer
Posted patch cleanup patch (obsolete) — Splinter Review
Attachment #254329 - Flags: review?(preed)
I think we got confused on the quoting convention.

Hash keys that aren't variables *should* have quotes, so:

$foo{'bar'}
$foo{$bar}

but NOT $foo{bar}.

There's one exception: the args style passing; so,

MyFunction(foo => 'bar', foo2 => $barTwo)
Yeah I see your point, it's easier to read if these are obviously strings.
Attachment #254329 - Attachment is obsolete: true
Attachment #254339 - Flags: review?(preed)
Attachment #254329 - Flags: review?(preed)
Comment on attachment 254339 [details] [diff] [review]
do not remove quotes from hash keys

Looks good; r=preed.
Attachment #254339 - Flags: review?(preed) → review+
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.