369042 - Bookmark for missing local file is wonky

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: One example of the wonky icon

STR:

1. Make a testcase somewhere on your HD
2. Bookmark said testcase
3. Forget about testcase (move it or delete it)
4. Open the Bookmarks Manager and wonder what the funny icon is

Actual: 32x32 generic file icon (may or may not be cropped strangely)
Expected: 16x16 generic file icon (or the icon we use for about:blank)

Comment 1

[froodian (Ian Leue)]

I'm having trouble reproing this, does it happen every time for you?

Comment 2

[froodian (Ian Leue)]

The answer to my question is "try to open the bookmark to see the wonkiness"

Comment 3

[froodian (Ian Leue)]

Attachment: Patch

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 253912 [details] [diff] [review]
Patch

This also fixes wonkiness with location bar icons in e.g., the testcase for bug 369427.

Comment 5

[Stuart Morgan]

Comment on attachment 253912 [details] [diff] [review]
Patch

I can't repro, but this seems reasonable; r=me.

Comment 6

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 253912 [details] [diff] [review]
Patch

sr=pink

Comment 7

[froodian (Ian Leue)]

Dewonkified on trunk and MOZILLA_1_8_BRANCH.