Closed
Bug 369099
Opened 18 years ago
Closed 18 years ago
[FIX]Static CellDataArray causes leak stat problems
Categories
(Core :: Layout: Tables, defect)
Core
Layout: Tables
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: benjamin, Assigned: bzbarsky)
References
()
Details
Attachments
(2 files, 1 obsolete file)
|
7.07 KB,
patch
|
Details | Diff | Splinter Review | |
|
944 bytes,
patch
|
Details | Diff | Splinter Review |
Spun off from bug 362318 comment 5 and 6: the static CellDataArray means that we get an assertion (because static data with initializers is bad), and could theoretically cause crashes on mac if layout got unloaded after XPCOM (which apparently sometimes does happen in real life).
Solution, initialize/destroy the structure in module ctor/dtor.
|
Assignee | |
Comment 1•18 years ago
|
||
Attachment #253837 -
Flags: superreview?(benjamin)
Attachment #253837 -
Flags: review?(bernd_mozilla)
|
|
Assignee | |
Updated•18 years ago
|
Summary: Static CellDataArray causes leak stat problems → [FIX]Static CellDataArray causes leak stat problems
Target Milestone: --- → mozilla1.9alpha
Boris, why don't you put it inside the cellmap ctor/dtor but the module ctor/dtor. Are you afraid of the memory consumption? The first would cause less intermodule dependencies or is there more that I don't know?
|
|
Assignee | |
Comment 3•18 years ago
|
||
This is a single array shared by all cellmaps... And I want to handle OOM allocating it. That wouldn't really work in the cellmap ctor, no?
Attachment #253837 -
Flags: review?(bernd_mozilla) → review+
|
|
Assignee | |
Updated•18 years ago
|
Attachment #253837 -
Flags: superreview?(benjamin) → superreview?(roc)
Attachment #253837 -
Flags: superreview?(roc) → superreview+
|
|
Assignee | |
Comment 4•18 years ago
|
||
Attachment #253837 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•18 years ago
|
||
Fixed.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 6•18 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•