[FIX]"ASSERTION: A frame but no DOM element!?" removing a <frame> whose onunload handler tries to load another page

RESOLVED FIXED

Status

()

Core
Document Navigation
RESOLVED FIXED
11 years ago
9 years ago

People

(Reporter: Jesse Ruderman, Assigned: bz)

Tracking

(Blocks: 1 bug, {assertion, testcase})

Trunk
x86
Mac OS X
assertion, testcase
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

11 years ago
Created attachment 253781 [details]
testcase

Loading the testcase triggers:

###!!! ASSERTION: A frame but no DOM element!?: 'requestingElement', file /Users/jruderman/trunk/mozilla/docshell/base/nsDocShell.cpp, line 6212
Created attachment 253795 [details] [diff] [review]
Fix

I should note that this makes the location set throw in this testcase.  I suppose I could just return NS_OK, but this seems more correct.
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #253795 - Flags: superreview?(jst)
Attachment #253795 - Flags: review?(jst)
(Reporter)

Comment 2

11 years ago
It currently throws NS_ERROR_FAILURE, so making it throw something else shouldn't be a problem.
Summary: "ASSERTION: A frame but no DOM element!?" removing a <frame> whose onunload handler tries to load another page → [FIX]"ASSERTION: A frame but no DOM element!?" removing a <frame> whose onunload handler tries to load another page
Comment on attachment 253795 [details] [diff] [review]
Fix

r+sr=jst
Attachment #253795 - Flags: superreview?(jst)
Attachment #253795 - Flags: superreview+
Attachment #253795 - Flags: review?(jst)
Attachment #253795 - Flags: review+
Fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Reporter)

Comment 5

10 years ago
Crashtest checked in.
Flags: in-testsuite+
(Reporter)

Comment 6

9 years ago
See also bug 443655, where a new testcase triggers the same assertion as this FIXED bug.
You need to log in before you can comment on or make changes to this bug.