Closed Bug 369198 Opened 18 years ago Closed 18 years ago

some characters missing at drawing

Categories

(Core :: Graphics, defect)

x86
Linux
defect
Not set
major

Tracking

()

RESOLVED FIXED

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

(Keywords: regression)

Attachments

(1 file)

Attached patch Patch rv1.0Splinter Review
this is a regression of new textrun. some characters (only some fonts with some style) are missing at drawing. this is a critical regression, we should fix this before a2. screenshot: http://bugzilla.mozilla.gr.jp/attachment.cgi?id=3464&action=view "とおや@もじ組" should be "とおやま@もじら組". In SetGlyphs, the complex cluster flag is not initialized. We should always initialize it. The SetGlyph might be aborted by |aAbortOnMissingGlyphs|.
Attachment #253865 - Flags: review?(roc)
Attachment #253865 - Flags: review?(vladimir)
I tried the patch rv1.0. It seems very good. The problems gone away. Thanks, Nakano-san.
Thank you, Masayuki. I was just going to file a bug about Hebrew and Arabic diacritics not being rendered correctly, but this patch fixes it.
Comment on attachment 253865 [details] [diff] [review] Patch rv1.0 good, thanks!!
Attachment #253865 - Flags: review?(roc) → review+
Comment on attachment 253865 [details] [diff] [review] Patch rv1.0 good, thanks!!
Attachment #253865 - Flags: review?(vladimir)
checked-in.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: