369254 - Drag/drop of site icon to other browser icon in dock fails

Status: RESOLVED FIXED

(Camino Graveyard :: Drag & Drop, defect)

Description

[philippe (part-time)]

Dragging (default) icon from location bar or tab to the Dock icon for other browser (any browser) fails to open page in target browser.
STR
1. load a web page (over http://)
2. drag site icon from location bar to dock icon of any other browser
3. watch nothing happening.

Dragging into open window works corectly. Dragging to desktop creates .webloc file correctly

Just in case:
user_pref("browser.chrome.favicons", false);

At one point I got this in Console log:
2007-02-04 20:39:36.467 Camino[19404] error in CoreDragDispose: -1850

Works: Version 2007020204 (1.2+)
Fails: Version 2007020222 (1.2+)
--> regression from bug 364198

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I assume dragging only worked on 10.4 to begin with?  I can't repro successful dragging on 10.3.9 with builds from before that date.

Comment 2

[philippe (part-time)]

You're right, that drag-and-drop to the Dock icon never seems to work on 10.3.
It definitely worked on 10.4, both on Trunk and Branch. Now it fails on both.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Confirming based on irc and targeting for 1.1 since it's a regression :(

Comment 4

[Stuart Morgan]

I wonder if this is maybe due to the 0-length file array case I was worried about.

Comment 5

[froodian (Ian Leue)]

Attachment: Patch

Only advertises file type if we have files.

Comment 6

[Stuart Morgan]

Comment on attachment 254599 [details] [diff] [review]
Patch

We don't want to put *only* files on the pasteboard; what if the target only accepts strings, or URLs?

Comment 7

[froodian (Ian Leue)]

Attachment: Patch

Oops, that declareTypes was supposed to be an addTypes.

Comment 8

[Stuart Morgan]

Have you tested this with apps that accept URLs and files? Putting it at the end of the list may not do the right thing for those apps.

Comment 9

[froodian (Ian Leue)]

Attachment: Patch

This also doesn't publish the file ref version if the file doesn't exist at drag time.  AFACT, this doesn't make any difference behaviorally (even when the file doesn't exist), but it's the Right Thing to do.

Comment 10

[Stuart Morgan]

Comment on attachment 254916 [details] [diff] [review]
Patch

r=me

Comment 11

[froodian (Ian Leue)]

Checked in on trunk and MOZILLA_1_8_BRANCH.