369407 - Make the history sidebar use the shared places context menu

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Asaf Romano (gone)]

Make the history sidebar use the shared places context menu (placesContext).

Doing so will also enable the context menu in the history sidebar for multiple selection, we have ui-r=mconnor on that.

Comment 1

[Asaf Romano (gone)]

Few more notes:
  1) The Expand/Collapse item is removed, this was already done for the
     bookmarks parallel item back in 1.5; approved by mconnor.
  2) The replacement for the "Copy Link Location" item is a simple "Copy" item
     which also copies the item title (for the purpose of pasting it as a
     bookmark). Note: the Accel+C keybinding and the Edit->Copy menuitem have
     both done this already; also approved by mconnor.
  3) We can easily make "Open All In Tabs" work for hosts. I will file a
     separate RFE.
  4) The "Get Info"/"Properties" menuitem may appear for bookmarked history
     items until the work for bug 360133 lands.

Comment 2

[Asaf Romano (gone)]

Attachment: patch

Comment 3

[Asaf Romano (gone)]

Attachment: patch

Comment 4

[(not reading, please use [e-mail] instead)]

thanks for all the references to ui-r from mconnor:

>  3) We can easily make "Open All In Tabs" work for hosts. I will file a
>  separate RFE.

sounds good!  Can we also do this for dates? ("Today")

reviewing this now.

Comment 5

[(not reading, please use [e-mail] instead)]

Comment on attachment 254453 [details] [diff] [review]
patch

r=sspitzer, please log a spin off bug about the "open in tabs" RFE.

Comment 6

[(not reading, please use [e-mail] instead)]

thanks again for fixing the history sidebar.

since we refer to mconnor's ui-r, might as well cc him and beltzner so they know about these changes.

Comment 7

[Asaf Romano (gone)]

mozilla/browser/components/places/content/controller.js 1.122
mozilla/browser/components/places/content/history-panel.js 1.10
mozilla/browser/components/places/content/history-panel.xul 1.7
mozilla/browser/components/places/content/menu.xml 1.65
mozilla/browser/components/places/content/placesOverlay.xul 1.5
mozilla/browser/components/places/content/toolbar.xml 1.71
mozilla/browser/components/places/content/tree.xml 1.51

Comment 8

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv