369552 - Uninstall reg key not removed on uninstall

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[Robert Strong (they/them - no direct email)]

Affects all Windows version though this is fallout from the Vista changes

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch

Comment 2

[(not reading, please use [e-mail] instead)]

Comment on attachment 254226 [details] [diff] [review]
patch

r=sspitzer

Comment 3

[Robert Strong (they/them - no direct email)]

Comment on attachment 254226 [details] [diff] [review]
patch

This is needed on the branch.

Comment 4

[Marcia Knous [:marcia]]

rstrong: Would this cause the Program to hang around in Add/Remove Programs even after you run the uninstaller? Just want to make sure that bug is covered since both juanb and I have seen it on Vista and XP.

Comment 5

[Robert Strong (they/them - no direct email)]

Yes

Comment 6

[Robert Strong (they/them - no direct email)]

Comment on attachment 254226 [details] [diff] [review]
patch

I'm going to double check a couple of things before request a1.8.1.2

Comment 7

[(not reading, please use [e-mail] instead)]

fwiw:

I just verified this fix with robert's new.exe

with his 98.exe (an old build from him), the program hangs around on vista after uninstall.  when uninstalling, I see the short path in the uninstall UI.

but, with his new.exe (a new build from him with this fix), the program doesn't hang around on vista after uninstall.  when uninstalling, I see the full path in the uninstall UI.

Comment 8

[(not reading, please use [e-mail] instead)]

note to robert:  trying 98.exe on my windows xp machine (which does not have your fix), after uninstalling the app, I do not see the program hanging around in Add/Remove Programs on windows XP.  (note, marcia did in comment #4).

There was a long delay, but as soon as the add/remove programs dialog came back, the program was no longer listed.

Comment 9

[Robert Strong (they/them - no direct email)]

Attachment: patch - also fix paths used

It also needs to uppercase the path since the compare is case sensitive on the branch. This did remove the values in startmenuinternet and uninstall.

Comment 10

[(not reading, please use [e-mail] instead)]

Comment on attachment 254240 [details] [diff] [review]
patch - also fix paths used

r=sspitzer

Comment 11

[(not reading, please use [e-mail] instead)]

> There was a long delay, but as soon as the add/remove programs dialog came
> back, the program was no longer listed.

note to robert:  fwiw, your new2.exe doesn't seem to have the long delay.  but the add/remove programs dialog can be slow, so your mileage may vary.

Comment 12

[Daniel Veditz [:dveditz]]

Comment on attachment 254240 [details] [diff] [review]
patch - also fix paths used

a=dveditz, land away on the 1.8 branch

Comment 13

[Robert Strong (they/them - no direct email)]

Checked in to MOZILLA_1_8_BRANCH - not needed for the trunk

Comment 14

[Carsten Book [:Tomcat]]

Verified fixed for 1.8.1.2 with Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.2pre) Gecko/20070207 BonEcho/2.0.0.2pre ID:2007020703

No hang around from this Build after uninstall and reg. key is also removed.