369581 - 'height:auto' non-box frames don't respect height of overridable nsITheme::GetMinimumWidgetSize

Status: NEW

(Core :: Layout, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

non-box frames with 'height: auto' (such as buttons) don't respect the height part of the result from nsITheme::GetMinimumWidgetSize when the canOverride out parameter is true.  This is because nsFrame::ComputeSize doesn't adjust a height that it NS_UNCONSTRAINEDSIZE.

I think the way we need to fix this is to set mComputedMinHeight in the reflow state.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

I think this should work.  It's against a tree from before Eli landed last night, and requires merging.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Merged with bug 177805.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Fix the comment too.

Comment 4

[Josh Aas]

Patch doesn't seem to work for me. I am specifying a minimum height of 20 for buttons and I am still getting native buttons with frame heights < 20.

Comment 5

[Josh Aas]

Attachment: test patch v1.0

If you apply this simple patch to a Firefox tree and then visit bugzilla.mozilla.org (the main page) you'll see button frames that are smaller then the minimum size specified. You can see that the button draws outside of the frame because it cannot draw smaller.