36965 - Preferences should use nsIFile

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect, P3)

Description

[Doug Turner (:dougt)]

In many places prefs uses nsFileSpec which is no longer supported

nsPref:

NTDLL! 77f7629c()
nsDebug::Assertion(const char * 0x100bb474, const char * 0x100bb470, const char 
* 0x100bb444, int 0x0000033c) line 191 + 13 bytes
nsFileSpec::nsFileSpec() line 828 + 34 bytes
nsFileLocator::GetFileLocation(nsFileLocator * const 0x00d16a40, unsigned int 
0x00010013, nsIFileSpec * * 0x0012fc5c) line 606
pref_InitInitialObjects() line 1226 + 61 bytes
PREF_Init(const char * 0x00000000) line 463 + 5 bytes
nsPref::StartUp(nsPref * const 0x00ccb4d0) line 306 + 7 bytes
nsPref::GetInstance() line 271

Comment 1

[Alec Flett]

I'd like to propose a transitional method to do this, so that we have 
GetPathPref and GetFilePref() at the same time, and phase out GetPathPref - the 
reason is that all mail paths originate from GetPathPref, so switching to 
nsIFile is going to be a big task for mail.

Adding putterman to the list because he expressed interest in this.

Comment 2

[Gagan]

prefs to mcafee

Comment 3

[Gagan]

argh... didn't work the last time. pardon the spam. ->mcafee

Comment 4

[Alec Flett]

I've started to work on this in my local tree, I'll try to post a patch here in 
the next few days.

Comment 5

[Chris McAfee]

back to alecf, post patch and pass on to
dveditz if necessary.

Comment 6

[scottputterman]

moving to M18 for the moment?  How important is this that this gets in this release?

Comment 7

[Alec Flett]

nominating for nsbeta3 -  the fewer consumers of nsIFileSpec, the smaller the
bloat.

Comment 8

[Alec Flett]

I have this ready in my tree.
Thanks to [e-mail] for adding the persistent file descriptor to
nsILocalFile

Comment 9

[Alec Flett]

cc'ing conrad because he's working with the patch right now

Comment 10

[Alec Flett]

ok, the new API is in, temporarilyi as getFileXPref and setFileXPref

When conrad and I have converted all consumers, I'll swap in the new APIs.

Comment 11

[Alec Flett]

actually, I'm going to mark this fixed because the conversion will happen in bug 
42102

Comment 12

[sairuh (rarely reading bugmail)]

marking fixed, as i assumed alecf meant to do (bugzilla coulda been have its
usual fits, so mighta missed your change. :-)

Comment 13

[Alec Flett]

heh, I forget to do that all the time...

Comment 14

[sairuh (rarely reading bugmail)]

backend fix, so rubberstamp vrfy.