369703 - Add protocol / file handler registry keys in HKEY_CURRENT_USER to workaround apps that read reg keys directly

Status: RESOLVED FIXED

(Firefox :: Shell Integration, enhancement)

Description

[Robert Strong (they/them - no direct email)]

It turns out that some applications (e.g. Yahoo IM) read the file and protocol handler registry keys to launch the default http, etc. handler as reported in bug 359643. Since Vista uses a new methodology for setting the default handler that does not set these keys apps that do this will not launch the actual default handler unless the default handler has also updated the associated registry keys. We can accomplish this by also setting the associated registry keys under HKEY_CURRENT_USER on Vista when setting ourselves as the default handler using the new method provided by Vista.

Comment 2

[Jay Patel [:jay]]

Might be too late for 1.8.1.2, but let's try to get a patch together quickly in case we can land it for rc1 or as part of any respins.

Comment 3

[Robert Strong (they/them - no direct email)]

Taking to get this on my radar

Comment 4

[Melvin Ganik]

The password storage application KeePass (v1.6, v1.7, etc) appears to use HKEY_CLASSES_ROOT\http\shell\open\command to open a browser.  (KeePass WinUtil.cpp lines 273 - 299. Note the "http\\shell\\open\\command" in line 280.) 

On Vista, with FF as the default browser, this key is still set to IE, and as a result KeePass opens IE instead of the default FF browser.

Perhaps KeePass needs to be updated for Vista, but will a solution to this bug fix this problem?  I ask this because the key used for KeePass does not come from the Current User area of the registry (it is from HKCR).

I wonder why the following keys are still set to IE when FF is the default browser:

[HKEY_CLASSES_ROOT\http\shell\open\command] 
@="\"C:\\Program Files\\Internet Explorer\\iexplore.exe\" -nohome" 
 
[HKEY_CLASSES_ROOT\http\shell\open\ddeexec\Application] 
@="IExplore" 
 
[HKEY_LOCAL_MACHINE\SOFTWARE\Classes\http\shell\open\command] 
@="\"C:\\Program Files\\Internet Explorer\\iexplore.exe\" -nohome" 
 
[HKEY_LOCAL_MACHINE\SOFTWARE\Classes\http\shell\open\ddeexec\Application] 
@="IExplore" 
 
Should these have been set to FF instead?

Comment 5

[Robert Strong (they/them - no direct email)]

(In reply to comment #4)
>...
> Should these have been set to FF instead?
No, the app that is reading those keys directly is at fault. This bug is about providing a workaround so misbehaving apps such as the one you mention will work properly

Comment 6

[Daniel Veditz [:dveditz]]

If the severity is enhancement is it really a blocker for 1.8.1.4?

Comment 7

[Robert Strong (they/them - no direct email)]

The severity is enhancement because this bug is about making our app work around a problem that exists in many other apps on Vista.

The changes required to work around this are a bit much to hold this for 1.8.1.4 at this time. I will continue to try to get this to a point where I am comfortable with the changes required.

Comment 8

[Robert Strong (they/them - no direct email)]

We can simplify this quite a bit by fixing bug 369783 so adding dependecy

Comment 9

[Mike Connor [:mconnor]]

Moving this off to M9 for now.

Comment 11

[Robert Strong (they/them - no direct email)]

Fixed by the landing of Bug 370571.