36972 - RDF should use nsIFile

Status: RESOLVED FIXED

(Core Graveyard :: RDF, defect, P3)

Description

[Doug Turner (:dougt)]

RDF should use nsIFile.  nsFileSpec is unsupported.

There are a few places that RDF uses nsFileSpec.  these should be converted.

Comment 1

[Chris Waterson]

i'll do this after nsbeta2, unless there is need to do it earlier...

Comment 2

[leger]

[NEED INFO] radar.

Comment 3

[Robert John Churchill]

From Darin:  (re: nsFileSpec usage nsLocalStore.cpp)

Take a look at NS_NewLocalFileInputStream and NS_NewLocalFileOutputStream in
nsIFileStreams.idl.  you might also want to wrap the output stream in a buffered
output stream (see NS_NewBufferedOutputStream).

Comment 4

[Robert John Churchill]

Attachment: Get nsFileSpec out of nsLocalStore.cpp

Get nsFileSpec out of nsLocalStore.cpp using Darin's suggested changes.

Comment 5

[Darin Fisher]

Comment on attachment 65358 [details] [diff] [review]
Get nsFileSpec out of nsLocalStore.cpp

>Index: mozilla/rdf/datasource/src/nsLocalStore.cpp

>+    nsXPIDLCString pathBuf;
>+    rv = aURI->GetSpec(getter_Copies(pathBuf));
>     if (NS_FAILED(rv)) return rv;

this patch looks great to me, but for my sanity could |pathBuf| be renamed
|specBuf| or just |spec|?

sr=darin

Comment 6

[Chris Waterson]

Comment on attachment 65358 [details] [diff] [review]
Get nsFileSpec out of nsLocalStore.cpp

>-        if (! spec.Exists())
>+        if (NS_SUCCEEDED(rv = aFile->Exists(&fileExistsFlag)) && (!fileExistsFlag))
>             return NS_ERROR_UNEXPECTED;

How about breaking this up:

  fileExistsFlag = PR_FALSE;
  aFile->Exists(&fileExistsFlag);
  if (! fileExistsFlag)
    return NS_ERROR_FAILURE;

(Is this really even necessary? What if we just let the local store get
created even though we can't write it? Failing here will lead to a trickle-
down failure and nothing will work...why not just fail when we try to write
it back?)

The rest looks fine, r=waterson.

Comment 7

[Robert John Churchill]

Fixed.

Comment 8

[benc]

tever is not RDF QA anymore