Closed Bug 36974 Opened 26 years ago Closed 23 years ago

Bookmark should use nsIFile

Categories

(SeaMonkey :: Bookmarks & History, defect, P5)

defect

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 191783
Future

People

(Reporter: dougt, Assigned: bugs)

References

Details

(Whiteboard: Blocked by 46394. Bookmarks use nsInputFileStream which only work with nsFileSpec)

Bookmark should use nsIFile. nsFileSpec is unsupported. NTDLL! 77f7629c() nsDebug::Assertion(const char * 0x100bb474, const char * 0x100bb470, const char * 0x100bb444, int 0x0000033c) line 191 + 13 bytes nsFileSpec::nsFileSpec() line 828 + 34 bytes nsBookmarksService::ReadBookmarks(nsBookmarksService * const 0x02999a50) line 4106 nsBookmarksService::Init() line 1941 + 12 bytes nsBookmarksServiceConstructor(nsISupports * 0x00000000, const nsID & {...}, void * * 0x0012efac) line 4841 + 146 bytes nsGenericFactory::CreateInstance(nsGenericFactory * const 0x02999b50, nsISupports * 0x00000000, const nsID & {...}, void * * 0x0012efac) line 48 nsComponentManagerImpl::CreateInstance(nsComponentManagerImpl * const 0x00c44370, const nsID & {...}, nsISupports * 0x00000000, const nsID & {...}, void * * 0x0012efac) line 1156 + 24 bytes
Keywords: nsbeta2
Target Milestone: --- → M17
[nsbeta2-], if renominated, please provide a user-level scenario showing what happens that is bad.
Whiteboard: [nsbeta2-]
Users will not be able to bookmark UNC paths.
Whiteboard: [nsbeta2-]
Does "UNC" mean non-ASCII?
Universal Naming Convention: It is a way to specify shared file objects: \\server\volume\path\filename In fact, if you bookmark a path like this, you will assert.
Putting on [nsbeta2-] radar.
Whiteboard: [nsbeta2-]
Move to M20 target milestone.
Target Milestone: M17 → M20
Nav triage team: [nsbeta3+]
Whiteboard: [nsbeta2-] → [nsbeta2-] [nsbeta3+]
Adding nsbeta3 keyword to bugs which already have nsbeta3 status markings so the queries don't get all screwed up.
Keywords: nsbeta3
Priority: P3 → P2
Status: NEW → ASSIGNED
Whiteboard: [nsbeta2-] [nsbeta3+] → [nsbeta2-] [nsbeta3+] Haven't touched this yet. Should be fairly easy though.
Depends on: 46394
Whiteboard: [nsbeta2-] [nsbeta3+] Haven't touched this yet. Should be fairly easy though. → [nsbeta2-] [nsbeta3+]Blocked by 46394. Bookmarks use nsInputFileStream which only work with nsFileSpec
PDT thinks this a P5. We can live without UNC bookmarks.
Priority: P2 → P5
Whiteboard: [nsbeta2-] [nsbeta3+]Blocked by 46394. Bookmarks use nsInputFileStream which only work with nsFileSpec → [nsbeta2-] [nsbeta3+][PDTP5] Blocked by 46394. Bookmarks use nsInputFileStream which only work with nsFileSpec
In agreement. We have marked other UNC related bugs Future. Workaround is to map the UNC path to a drive letter.
renominating for beta3 per last two comments. I don't think this is a beta3 stopper.
Whiteboard: [nsbeta2-] [nsbeta3+][PDTP5] Blocked by 46394. Bookmarks use nsInputFileStream which only work with nsFileSpec → [nsbeta2-][PDTP5] Blocked by 46394. Bookmarks use nsInputFileStream which only work with nsFileSpec
'renominating' makes it sound like this bug got minused are you are now advocating that it be +'d. Viewing the bug activity has made me understand that instead you have "removed the nsbeta3+ because you don't believe it to be worthy of that status and would like it to be reconsidered."
Blake probably renominated this to change it from nsbeta3+ to nebeta3-.
46394 was marked nsbeta3-, so unless its status changes, this will not get fix either. I added some comments to that bug (owned by warren) to see if that is ok.
Sorry for any ambiguity...I *don't* think this is a beta3 stopper, so I'd like it to be reconsidered. Especially since it's dependant on a minused bug, as steve points out.
Nav triage team: nsbeta3- :(
Whiteboard: [nsbeta2-][PDTP5] Blocked by 46394. Bookmarks use nsInputFileStream which only work with nsFileSpec → [nsbeta2-][PDTP5][nsbeta3-] Blocked by 46394. Bookmarks use nsInputFileStream which only work with nsFileSpec
Reassigning 79 Bookmarks bugs to Ben. I was told this was going to be done shortly about two months ago, but it clearly hasn't been. I think that's long enough for all these bugs to remain assigned to nobody. Feel free to filter all this spam into the trashcan by looking for this string in the message body: ducksgoquack
Assignee: slamm → ben
Status: ASSIGNED → NEW
Netscape Nav triage team: this is not a Netscape beta stopper.
Keywords: nsbeta1-
Marking nsbeta1- bugs as future to get off the radar.
Target Milestone: --- → Future
Status: NEW → ASSIGNED
Paul Chen is now taking Bookmarks bugs. For your convenience, you can filter email notifications caused by this by searching for 'ilikegoats'.
Assignee: ben → pchen
Status: ASSIGNED → NEW
Removing adequated PDT grafitti.
Whiteboard: [nsbeta2-][PDTP5][nsbeta3-] Blocked by 46394. Bookmarks use nsInputFileStream which only work with nsFileSpec → Blocked by 46394. Bookmarks use nsInputFileStream which only work with nsFileSpec
mass reassign of pchen bookmark bugs to ben
Assignee: pchen → ben
*** This bug has been marked as a duplicate of 191783 ***
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → DUPLICATE
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.