369917 - [0.3.1][it] wrong locale in useragent, missing default preferences

Status: VERIFIED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Stefan Sitter [:ssitter]]

Italian Sunbird 0.3.1 identifies itself as Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20070208 Sunbird/0.3.1

Reason is that in l10n/it/calendar/sunbird-l10n.js preference "general.useragent.locale" is not set. The file also misses default values for "calendar.week.start" and "calendar.week.d...off".

See http://lxr.mozilla.org/mozilla/source/calendar/locales/en-US/sunbird-l10n.js for example

Comment 1

[Iacopo Benesperi [:iacchi]]

Attachment: Fix for sunbird-l10n.js

Fully localized sunbird-l10n.js for it-IT locale

Comment 2

[Iacopo Benesperi [:iacchi]]

Attachment: sunbird-l10n.js fix - 2nd try

Fixed locale string

Comment 3

[Stefan Sitter [:ssitter]]

Comment on attachment 254579 [details]
sunbird-l10n.js fix - 2nd try

The file looks ok to me.
Can you commit it to SUNBIRD_0_3_BRANCH (and the other branches/trunk) before todays nightly build is produced?

Comment 4

[Iacopo Benesperi [:iacchi]]

File committed to SUNBIRD_0_3_BRANCH and LIGHTNING_0_3_BRANCH, tell me if I should commit it to other branches/trunk

Comment 5

[cmtalbert]

Marking as fixed for 0.3.1

Comment 6

[Matthew (lilmatt) Willis]

Iacopo:
Please commit to MOZILLA_1_8_BRANCH and trunk as well so your fixes appear in future Sunbird/Lightning versions.

I've moved the release tag forward on the Italian files that were checked in.  Sunbird + it locales that are built after this time should include the fixes.

Comment 7

[Stefan Sitter [:ssitter]]

Verified using Mozilla/5.0 (X11; U; Linux i686; it; rv:1.9a1) Gecko/20070212 Sunbird/0.3.1