369918 - Crash Loading a Saved Search Folder [ nsMsgQuickSearchDBView::OnSearchDone]

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect, P3)

Description

[Scott MacGregor]

Using today's branch nightly on Windows.

I was running 1.5.0.9 testing something out. Then I went back to Thunderbird 2, clicked on a saved search folder that spans multiple accounts and crashed. Restarting and I still crashed.

Note: this sure does look a lot like Bug 352287

TB29181688

nsMsgQuickSearchDBView::OnSearchDone  [mozilla/mailnews/base/src/nsMsgQuickSearchDBView.cpp, line 270]
nsMsgSearchSession::NotifyListenersDone  [mozilla/mailnews/base/search/src/nsMsgSearchSession.cpp, line 608]
nsMsgSearchSession::TimerCallback  [mozilla/mailnews/base/search/src/nsMsgSearchSession.cpp, line 540]
nsTimerImpl::Fire  [mozilla/xpcom/threads/nsTimerImpl.cpp, line 394]

Comment 1

[David :Bienvenu]

if your saved search folder spans multiple accounts, why whould we be in nsMsgQuickSearchDBView::OnSearchDone? Were you in a view in the saved search folder?

Comment 2

[Scott MacGregor]

Hmm, I could have sworn it used to span multiple folders (not multiple accounts). 

After running in a debug trunk build, I'm able to load the folder again without crashing and verified that it's just searching a single folder.

I think something weird happened when I went back to 1.5 and then back to tb2. The first time I ran none of my virtual folders loaded, then the second time I ran, I got a bunch of saved search folders that I haven't seen in a long time. Then those disappeared after a couple crashes loading that one search.

David, can you try running 1.5 and seeing if you notice anything weird the first time you run tb2 after that?

Comment 3

[David :Bienvenu]

I run 1.5 quite a bit more than I'd like to :-) and I haven't seen this issue. But I really only have one saved search that I use regularly, which checks all my inboxes and filter targets for new mail. I know I've used that with 1.5, because I notice how slow it is compared to 2.0...

anything special about the folders the saved search searched over? e.g., folder names that needed encoding? or the saved search itself?

Comment 4

[Iain Hallam]

Just seen this on TB2.0.0.0 on upgrading from TB1.5.0.12:

http://talkback-public.mozilla.org/search/start.jsp?search=2&type=iid&id=32884310
http://talkback-public.mozilla.org/search/start.jsp?search=2&type=iid&id=32884789

This doesn't happen with a blank profile created in TB2.

Comment 5

[Iain Hallam]

To update, I have today installed TB2 on a different machine and, knowing about the problems I had yesterday, started with a blank profile. Same bug manifested itself, unfortunately:

http://talkback-public.mozilla.org/search/start.jsp?search=2&type=iid&id=32912807
http://talkback-public.mozilla.org/search/start.jsp?search=2&type=iid&id=32912828

Comment 6

[Wayne Mery (:wsmwk)]

Ian, have you seen the crash since with newer v2?

Comment 7

[Tom Simnett]

I have now started seeing this issue. I used to have a search folder that did a basic search on "From:" and Tags contains. The search itself works fine, and the Search Folder is created. Clicking on the Folder however produces a crash. All other search folders seem to work ok, except for this one. And the name of it doesn't appear to be relevant.

Tom

Comment 8

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

RefreshCache can fail at least via nsMsgDatabase::GetSearchResultsTable() and by OOM

Comment 9

[David :Bienvenu]

Comment on attachment 329256 [details] [diff] [review]
proposed fix

I think OOM is the only realistic way it can fail, so I don't know that this patch is going to fix the problem. RefreshCache tells GetSearchResultsTable to create the table if it's missing and that generally succeeds, bar OOM. But, we should check for the error.

Comment 10

[Magnus Melin [:mkmelin]]

Checking in mailnews/base/src/nsMsgQuickSearchDBView.cpp;
/cvsroot/mozilla/mailnews/base/src/nsMsgQuickSearchDBView.cpp,v  <--  nsMsgQuickSearchDBView.cpp
new revision: 1.37; previous revision: 1.36
done

->FIXED (hopefully, if it still crashes we can open a new bug for that)

Comment 12

[Magnus Melin [:mkmelin]]

Attachment: proposed fix (1.8 branch)

Just adding an rv check, should be very safe for branch too.

Comment 13

[Patrick]

Any news on this? When will the fix be in a release version? This bug effectively renders the (great) 'Saved Search Folder' feature unusable for me.

Comment 14

[Phil Ringnalda (:philor)]

Magnus: stepping on your toes with a checkin-needed, since the branch code freeze is in eight hours.

Comment 15

[Phil Ringnalda (:philor)]

mailnews/base/src/nsMsgQuickSearchDBView.cpp 1.13.8.12

Comment 16

[Magnus Melin [:mkmelin]]

Thx Phil!
Patrick: this will be in thunderbird 2.0.0.17.

Comment 17

[Patrick]

Great news! :)

Comment 18

[Al Billings [:abillings - ex-MoCo]]

I can't reproduce this bug cleanly. Can someone verify the fix in the release candidate for TB 2.0.0.17 at ftp://ftp.mozilla.org/pub/thunderbird/nightly/2.0.0.17-candidates/build1/ ?

Comment 19

[Patrick]

(In reply to comment #18)
> I can't reproduce this bug cleanly. Can someone verify the fix in the release
> candidate for TB 2.0.0.17 at
> ftp://ftp.mozilla.org/pub/thunderbird/nightly/2.0.0.17-candidates/build1/ ?

It also doesn't happen in 100% of the times I click on a search folder for me. I think when Thunderbird is freshly started, it's more likely to happen.

Just now I did some testing:
TB 2.0.0.16 crashed (verified, multiple times).
TB 2.0.0.17rc (downloaded a few minutes ago, used the same profile): I tried ~30 times, restarted it, restarted the whole system, tried again - no crash. So: seems to work!

Thanks a lot for fixing this! :)

Comment 20

[Al Billings [:abillings - ex-MoCo]]

Marking this as verified then. I sounds like the fix worked. :-)