Closed
Bug 369928
Opened 18 years ago
Closed 18 years ago
String "items failed to import. The last error was:" in import-export.js is not localized
Categories
(Calendar :: Import and Export, defect)
Calendar
Import and Export
Tracking
(Not tracked)
VERIFIED
FIXED
Sunbird 0.5
People
(Reporter: hubert+bmo, Assigned: ssitter)
References
()
Details
Attachments
(3 files)
4.61 KB,
patch
|
mattwillis
:
first-review+
|
Details | Diff | Splinter Review |
18.64 KB,
image/png
|
Details | |
18.64 KB,
image/png
|
Details |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; pl-PL; rv:1.8.1.2pre) Gecko/20061023 SUSE/2.0.0.1-0.1 Firefox/2.0.0.2pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.9a1) Gecko/20070208 Sunbird/0.3.1
I tried to import calendar from ics file.
Reproducible: Always
Steps to Reproduce:
1. CTRL+I
2. Choose file
3. If you see "Select Calendar" window - you'll select any calendar
4. OK
Actual Results:
... items failed to import. The last error was: ...
Expected Results:
This string should be localized.
Updated•18 years ago
|
Summary: String "items failed to import. The last error was:" in import-export.js is not localized → [0.3.1][pl] String "items failed to import. The last error was:" in import-export.js is not localized
Comment 1•18 years ago
|
||
This isn't a pl issue.
It's a hard-coded string that needs to be localizeable.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking-calendar0.5+
OS: Linux → All
Hardware: PC → All
Summary: [0.3.1][pl] String "items failed to import. The last error was:" in import-export.js is not localized → String "items failed to import. The last error was:" in import-export.js is not localized
Target Milestone: --- → Sunbird 0.5
Version: unspecified → Trunk
Assignee | ||
Updated•18 years ago
|
Whiteboard: [l10n impact]
Assignee | ||
Comment 3•18 years ago
|
||
Remove hard coded string and make it translatable.
Extend calGetString() helper function to also work for formatted strings. I think this will be very useful for many other code places too.
Attachment #257722 -
Flags: first-review?(lilmatt)
Assignee | ||
Updated•18 years ago
|
Status: NEW → ASSIGNED
Comment 4•18 years ago
|
||
Comment on attachment 257722 [details] [diff] [review]
rev0 - remove hard coded string
Nice work.
r=lilmatt
Attachment #257722 -
Flags: first-review?(lilmatt) → first-review+
Comment 5•18 years ago
|
||
Patch checked in on MOZILLA_1_8_BRANCH and trunk.
-> FIXED
Updated•18 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 6•18 years ago
|
||
Verified on Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.8.1.4pre) Gecko/20070524 Sunbird/0.5
Reporter | ||
Comment 7•18 years ago
|
||
Verified on Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.8.1.4pre) Gecko/20070524 Sunbird/0.5
Reporter | ||
Updated•18 years ago
|
Status: RESOLVED → VERIFIED
Updated•17 years ago
|
Flags: blocking-calendar0.5+
Updated•17 years ago
|
Whiteboard: [l10n impact]
You need to log in
before you can comment on or make changes to this bug.
Description
•