Closed Bug 369928 Opened 17 years ago Closed 17 years ago

String "items failed to import. The last error was:" in import-export.js is not localized

Categories

(Calendar :: Import and Export, defect)

Product:
Calendar
Component:
Import and Export
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Sunbird 0.5

People

(Reporter: hubert+bmo, Assigned: ssitter)

References

(
URL
)

Details

Attachments

(3 files)

rev0 - remove hard coded string
4.61 KB, patch
mattwillis
: first-review+
Details | Diff | Splinter Review
Verified (string is localized)
18.64 KB, image/png
Details
Verified (strig is localized)
18.64 KB, image/png
Details 
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; pl-PL; rv:1.8.1.2pre) Gecko/20061023 SUSE/2.0.0.1-0.1 Firefox/2.0.0.2pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.9a1) Gecko/20070208 Sunbird/0.3.1

I tried to import calendar from ics file.

Reproducible: Always

Steps to Reproduce:
1. CTRL+I
2. Choose file
3. If you see "Select Calendar" window - you'll select any calendar
4. OK
Actual Results:  
... items failed to import. The last error was: ...

Expected Results:  
This string should be localized.
Summary: String "items failed to import. The last error was:" in import-export.js is not localized → [0.3.1][pl] String "items failed to import. The last error was:" in import-export.js is not localized
This isn't a pl issue.
It's a hard-coded string that needs to be localizeable.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking-calendar0.5+
OS: Linux → All
Hardware: PC → All
Summary: [0.3.1][pl] String "items failed to import. The last error was:" in import-export.js is not localized → String "items failed to import. The last error was:" in import-export.js is not localized
Target Milestone: --- → Sunbird 0.5
Version: unspecified → Trunk
Whiteboard: [l10n impact]
I'm working on this.
Assignee: nobody → ssitter
Remove hard coded string and make it translatable. 
Extend calGetString() helper function to also work for formatted strings. I think this will be very useful for many other code places too.
Attachment #257722 - Flags: first-review?(lilmatt)
Status: NEW → ASSIGNED
Comment on attachment 257722 [details] [diff] [review]
rev0 - remove hard coded string

Nice work.

r=lilmatt
Attachment #257722 - Flags: first-review?(lilmatt) → first-review+
Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Verified on Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.8.1.4pre) Gecko/20070524 Sunbird/0.5
Verified on Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.8.1.4pre) Gecko/20070524 Sunbird/0.5
Status: RESOLVED → VERIFIED
Flags: blocking-calendar0.5+
Whiteboard: [l10n impact]
You need to log in before you can comment on or make changes to this bug.