369992 - Areas previously occupied by a foreignObject aren't repainted

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jonathan Watt [:jwatt]]

Attachment: testcase

When a foreignObject is moved, the area it previously covered is not repainted. The content of the foreignObject then appears in two places.

Comment 1

[Jonathan Watt [:jwatt]]

So the only possible caller of nsSVGDisplayContainerFrame::UpdateCoveredRegion is nsSVGMarkerFrame::RegionMark. Why doesn't anyone else need to call it? Alternatively, is it still necessary to call it there at all?

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: patch

Anyway, I guess nsSVGForeignObjectFrame should be doing something more like nsSVGPathGeometryFrame. The current problem is that the old area isn't invalidated before the covered region mRect is updated.

Comment 3

[tor]

Comment on attachment 254829 [details] [diff] [review]
patch

This will need updating for bug 369911, and NotifyRedrawUnsuspended should probably check the SVG_DIRTY bit.

Comment 4

[Jonathan Watt [:jwatt]]

Attachment: patch v2

Yeah, that's a fairly trivial update from Robert's or my side.

Comment 5

[Jonathan Watt [:jwatt]]

Attachment: patch v2 updated to tip

Robert landed his fix for bug 369911. Here's the updated patch.

Comment 6

[Robert Longson [:longsonr]]

I suspect Bug 358718 is a duplicate of this.

Comment 7

[Jonathan Watt [:jwatt]]

No, that bug is invalid.

Comment 8

[tor]

Comment on attachment 254931 [details] [diff] [review]
patch v2 updated to tip


> nsSVGForeignObjectFrame::NotifyRedrawUnsuspended()
> {
>-  if (!(mParent->GetStateBits() & NS_STATE_SVG_NONDISPLAY_CHILD))
>-    FlushDirtyRegion();
>+  if (!(mParent->GetStateBits() & NS_STATE_SVG_NONDISPLAY_CHILD)) {
>+    if (GetStateBits() & NS_STATE_SVG_DIRTY) {
>+      UpdateGraphic();
>+    }
>+    else {

Prevailing mozilla style is "} else {".

Comment 9

[Jonathan Watt [:jwatt]]

Checked in with style change.

Comment 10

[Jonathan Watt [:jwatt]]

Reftest is:
http://lxr.mozilla.org/seamonkey/source/layout/reftests/svg/foreignObject-move-repaint-01.svg