370121 - Clicking on red/yellow warning text in certificate panel causes text to change to black

Status: RESOLVED FIXED

(Camino Graveyard :: Security, defect)

Description

[Trevor Johns]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en; rv:1.8.1.2pre) Gecko/20070210 Camino/1.1a2+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en; rv:1.8.1.2pre) Gecko/20070210 Camino/1.1a2+

When visiting a site that has an invalid or untrusted SSL/TLS certificate, a warning panel is presented containing the certificate details and the error which occurred while validating that certificate. Normally this error is displayed in red text. However, if a user clicks on that text, it changes to black for no apparent reason.

Reproducible: Always

Steps to Reproduce:
1. Visit a site that uses HTTPS has an invalid or self-signed SSL certificate.
2. When the certificate warning panel appears, click on the red or yellow error text.

Actual Results:  
The warning text changes to black.

Expected Results:  
The warning text should remain the same color.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Yep.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Some additional STR:

1. https://www.a-trust.at/
2. Add exception
3. Click on the red error message in the cert view

Or

1. Open the Certificates window in Security prefs, switch to Authorities.
2. Double-click on an authority that has red text in the Validity column
3. Click on the red error message in the cert view

ER: The red error message text remains red
AR: The red error message text switches to black

Comment 4

[Christopher Henderson]

Attachment: Fix v1.0

Set the text colour of the field directly.

Comment 5

[Chris Lawson (gone)]

Comment on attachment 407455 [details] [diff] [review]
Fix v1.0

CertificateItem doesn't declare textColorForValidity to be public, so this doesn't build. (The patch as uploaded also has an offset due to the recent landing of bug 383988, but that's not a big deal.)

Comment 6

[Christopher Henderson]

Attachment: Fix v1.1

Hey, let's try it this way! Gets the text colour from the attributed string, rather than making that method public.

Comment 7

[Chris Lawson (gone)]

Comment on attachment 408248 [details] [diff] [review]
Fix v1.1

Builds and works as expected (still has a 10-line offset, though).

Comment 8

[Christopher Henderson]

Attachment: Fix v1.1, offset fixed

Fixed the offset; code is the same as v1.1.

Comment 9

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 408466 [details] [diff] [review]
Fix v1.1, offset fixed

sr=pink

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on cvs trunk and CAMINO_2_0_BRANCH for Camino 2.0.1.

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

This actually works on 1.6.x, too, so we probably should take it there, too, just to lessen the "is this broken?" appearance of our security UI.

Comment 12

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on cvs trunk in advance of 1.6.11.

Comment 13

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #12)
> Landed on cvs trunk in advance of 1.6.11.

s/cvs trunk/MOZILLA_1_8_BRANCH/