370219 - add xpicleanup.dat to removed-files.in on trunk and MOZILLA_1_8_BRANCH

Status: RESOLVED WONTFIX

(Toolkit :: Application Update, defect)

Description

[(not reading, please use [e-mail] instead)]

spun off from bug #369937

if there was a respin of 2.0.0.2, I'd like this to be considered.

Comment 1

[(not reading, please use [e-mail] instead)]

as robert indicated, when we do an install or when software update runs, if we detect this file, we could (and should) remove it, to help reduce issues like those reported in the forums such as:

http://forums.mozillazine.org/viewtopic.php?p=2736957 and
http://forums.mozillazine.org/viewtopic.php?p=2737780

note, this would be trunk and 1.8 branch only, and not the 1.8.0 branch, where we still use the xpinstaller.

dveditz, what do you think?

Comment 2

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 4

[(not reading, please use [e-mail] instead)]

clearing blocking, until we are sure we want this.

I haven't heard from dveditz, but I think rob strong has chatted with him about this, and we may not want it.

dan, can you elaborate on the risks?

Comment 5

[(not reading, please use [e-mail] instead)]

Comment on attachment 254894 [details] [diff] [review]
patch

clearing review requests

Comment 6

[(not reading, please use [e-mail] instead)]

I think we should still discuss this.

we may only want to do this on install (instead of on install and after software update).  if we do that, the fix would be to just the browser/installer/windows/nsis/installer.nsi, like we did for bug #368661

dveditz, what do you think?  (sending it over to you, for consideration.)

Comment 12

[Robert Strong (they/them - no direct email)]

This hasn't been an issue for a while now so resolving - wontfix