370387 - In Advanced/General/Choose "en-US" (set via intl.accept_languages) is not match to "en-us"

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect)

Description

[bugzilla2005]

User-Agent:       Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.8.1.1) Gecko/20061221 Firefox/2.0.0.1
Build Identifier: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.8.1.1) Gecko/20061221 Firefox/2.0.0.1

Advanced/General/Choose does not perform language tag matching in a case-insensitive manner: It does, e.g., not match "en-US" (set via intl.accept_languages) to "en-us (English/United States)"; instead, it simly displays "en-US" without the explanatory "(English/United States)" text.

But language tags are case-insensitive -- and uppercase country subtags are actually preferred (FWIW: maybe you could follow this convention as well.)

Reproducible: Always

Steps to Reproduce:
1. Set (using about:config) "intl.accept_languages" to "en-US"
2. Open Preferences/Advanced/General/Choose...

Actual Results:  
The "languages in order of prefernece" list now contains an "en-US" entry 

Expected Results:  
I would have expected to see either "en-US (English/United States)" or "en-us (English/United States)", since language tags are case-insensitive and hence a match for "en-US" ought to be found.

I stumbled upon this problem when manually setting intl.accept_languages to include de-DE-1901 as well; doing that I also normalized the country subtags to uppercase.

Comment 1

[Simon Montagu :smontagu]

Attachment: Patch

Comment 2

[Simon Montagu :smontagu]

(In reply to comment #0)
> But language tags are case-insensitive -- and uppercase country subtags are
> actually preferred (FWIW: maybe you could follow this convention as well.)

This was suggested in bug 44063 and resolved INVALID. I may reconsider it in bug 356038.

Comment 3

[Asaf Romano (gone)]

Comment on attachment 255204 [details] [diff] [review]
Patch

r=mano

Comment 4

[Simon Montagu :smontagu]

Checked in. Keeping the bug open for suite.

Comment 5

[Simon Montagu :smontagu]

Reducing severity, since in suite you can add languages from the preferences UI without resorting to about:config, and that scenario doesn't have the bug.

Comment 6

[Serge Gautherie (:sgautherie)]

(Filter "spam" on 'prefs-nobody-20080612'.)

Comment 7

[Philip Chee]

Attachment: Patch Sv1.0 Suite fix.

> Simon Montagu      2007-02-15 08:42:15 PST
> 
> Checked in. Keeping the bug open for suite.
Fix Suite (finally).

Comment 8

[Philip Chee]

Pushed to comm-central.
http://hg.mozilla.org/comm-central/rev/0297879cb2d2