370390 - can't drag an event to a previous day in weekview

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Michiel van Leeuwen (email: mvl+moz@)]

In weekview, when dragging an item to a previous day (say from today to yesterday), the event moves to somewhere in 2002.

Comment 1

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: patch caldatetime

The problem was in calDateTime. Subtracting dates did not work properly with unsigned numbers. PR_USEC_PER_SEC is unsigned, and then the division fails. Making it signed fixed the problem

Comment 2

[Daniel Boelzle [:dbo]]

Comment on attachment 255100 [details] [diff] [review]
patch caldatetime

Side-Note: my msvc doesn't show this problem, seems to promote UL literal to __int64 for division.
1st r=dbo.

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in.
Might indeed be a gcc only problem.

Comment 4

[Daniel Boelzle [:dbo]]

(In reply to comment #3)
> Might indeed be a gcc only problem.

Hmm. I don't know whether this is really a problem of gcc or something that's left open: The C++ standard states that e.g. dividing a long and an unsigned short, the unsigned short is to be promoted to signed long if it can be converted safely (which it can). In this case we do a division long long and unsigned long (literal). So (extrapolating) the standard, we could assume to safely deduce it to signed, but...
Anyway, long long is not standardized, so it's safe (and clearer) to put in the cast.