370394 - Password Manager prompts to change stored password on a 1xinput=text+3xinput=password form with all inputs having different values

Status: RESOLVED WORKSFORME

(Toolkit :: Password Manager, defect)

Description

[Stephen Connolly]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1

[May be related to 313204]

[I may have stripped this back a bit too far]

<form onSubmit="" action="login" method="POST" id="login" name="login" autocomplete="off">
<input value="" id="Name" name="Name" maxlength="" size="" type="text" class="formfield" />
<input value="" id="Pwd" name="Pwd" maxlength="" size="" type="password" class="formfield" autocomplete="off" />
<input value="" id="ConfRef" name="ConfRef" maxlength="" size="" type="password" class="formfield" autocomplete="off" />
<input value="" id="Pin" name="Pin" maxlength="" size="" type="password" class="formfield" autocomplete="off" />
<input name="SaveInputValues" id="SaveInputValues" type="checkbox" />
<input value="Login" name="" id="" type="submit" class="formButton" />
</form>

Have tried without autocomplete="off" as well.

Reproducible: Always

Steps to Reproduce:
Basically, the user enters their username, password, confref and confpin.  All three of the password, confref and confpin must remain hidden for security reasons.


Actual Results:  
The password manager sees three password inputs and a text input, decides that we must be changing our password and prompts to store.



Expected Results:  
There should be some logic that checks if the other two password fields have the same value and does not prompt if the values are different.

Comment 1

[u279076]

This has been fixed on trunk.  Password Manager is not invoked when three password fields are used on the same page.

Comment 2

[Justin Dolske [:Dolske]]

(just to be precise... The PM can process a 3-password form in some cases, but when all 3 fields are different it will just be ignored when submitted)

Comment 3

[Stephen Connolly]

Great.  Any idea where this fix is on the roadmap (i.e. when will it get released?)

Comment 4

[u279076]

To take a page from Blizzard's book:

It will be out when it is out.

Comment 5

[u279076]

In the mean time, you could always play around with the nightly

Comment 6

[Stephen Connolly]

OK, perhaps I should have been a bit more specific...

Will this be included in Firefox 2.0.0.x and if so, what value of x will that be?

What are the changes that x==5?

Comment 7

[Justin Dolske [:Dolske]]

There are currently no plans to fix this in FF2.