Closed
Bug 370398
Opened 18 years ago
Closed 17 years ago
Dependency graph wrong url path under mod_perl
Categories
(Bugzilla :: Dependency Views, defect, P2)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.0
People
(Reporter: ycombarnous, Assigned: mkanat)
Details
Attachments
(1 file)
668 bytes,
patch
|
LpSolit
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1 Build Identifier: When clicking on dependency graph, no image is shown. When looking into the webdot folder, the map and png files are correct. When looking at the html code, the output is wrong: <img src="/data/webdot/0duVPDmyxI.png" alt="Dependency graph" usemap="#imagemap"> As the bugzilla url is $IP/bugzilla, above will look for the png in $IP/data/webdot... instead of $IP/bugzilla/data/webdot.. Correct HTML output should be: <img src="data/webdot/0duVPDmyxI.png" alt="Dependency graph" usemap="#imagemap"> Reproducible: Always Steps to Reproduce: 1. 2. 3.
Summary: Dependency graph do not show up → Dependency graph wrong url path
Comment 1•18 years ago
|
||
(In reply to comment #0) > When looking at the html code, the output is wrong: > > <img src="/data/webdot/0duVPDmyxI.png" alt="Dependency graph" > usemap="#imagemap"> Note that the leading "/" appears with mod_perl only.
Assignee | ||
Comment 2•18 years ago
|
||
Yes, I can reproduce this in a mod_perl installation, but not in a mod_cgi installation. This also exposes a problem with our architecture--the data/ directory should not contain web-accessible items, as packagers may want to move it into /var.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 2000 → All
Hardware: PC → All
Summary: Dependency graph wrong url path → Dependency graph wrong url path under mod_perl
Target Milestone: --- → Bugzilla 3.0
Comment 3•17 years ago
|
||
Max, maybe should we consider this bug for 3.0.1. This is a "regression" compared to 2.22.
Assignee | ||
Comment 4•17 years ago
|
||
Yes, you're right. This is a pretty high priority to fix.
Assignee: dependency.views → mkanat
Flags: blocking3.0.1+
Priority: -- → P2
Assignee | ||
Comment 5•17 years ago
|
||
One-line fix. :-) Applied at: http://landfill.bugzilla.org/mod_perl/
Attachment #273772 -
Flags: review?(LpSolit)
Comment 6•17 years ago
|
||
Comment on attachment 273772 [details] [diff] [review] v1 Looks good and doesn't break mod-cgi. r=LpSolit
Attachment #273772 -
Flags: review?(LpSolit) → review+
Updated•17 years ago
|
Status: NEW → ASSIGNED
Flags: approval3.0+
Flags: approval+
Assignee | ||
Comment 7•17 years ago
|
||
tip: Checking in showdependencygraph.cgi; /cvsroot/mozilla/webtools/bugzilla/showdependencygraph.cgi,v <-- showdependencygraph.cgi new revision: 1.62; previous revision: 1.61 done 3.0: Checking in showdependencygraph.cgi; /cvsroot/mozilla/webtools/bugzilla/showdependencygraph.cgi,v <-- showdependencygraph.cgi new revision: 1.56.2.3; previous revision: 1.56.2.2 done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•