Dependency graph wrong url path under mod_perl

RESOLVED FIXED in Bugzilla 3.0

Status

()

Bugzilla
Dependency Views
P2
major
RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: Yann, Assigned: Max Kanat-Alexander)

Tracking

2.23.4
Bugzilla 3.0
Bug Flags:
approval +
approval3.0 +
blocking3.0.1 +

Details

Attachments

(1 attachment)

v1
668 bytes, patch
Frédéric Buclin
: review+
Details | Diff | Splinter Review
(Reporter)

Description

11 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1
Build Identifier: 

When clicking on dependency graph, no image is shown.
When looking into the webdot folder, the map and png files are correct.

When looking at the html code, the output is wrong: 

<img src="/data/webdot/0duVPDmyxI.png" alt="Dependency graph" usemap="#imagemap">

As the bugzilla url is $IP/bugzilla, above will look for the png in $IP/data/webdot... instead of $IP/bugzilla/data/webdot..

Correct HTML output should be:
<img src="data/webdot/0duVPDmyxI.png" alt="Dependency graph" usemap="#imagemap">

Reproducible: Always

Steps to Reproduce:
1.
2.
3.
(Reporter)

Updated

11 years ago
Version: unspecified → 2.23.4
(Reporter)

Updated

11 years ago
Summary: Dependency graph do not show up → Dependency graph wrong url path

Comment 1

11 years ago
(In reply to comment #0)
> When looking at the html code, the output is wrong: 
> 
> <img src="/data/webdot/0duVPDmyxI.png" alt="Dependency graph"
> usemap="#imagemap">

Note that the leading "/" appears with mod_perl only.
(Assignee)

Comment 2

11 years ago
Yes, I can reproduce this in a mod_perl installation, but not in a mod_cgi installation.

This also exposes a problem with our architecture--the data/ directory should not contain web-accessible items, as packagers may want to move it into /var.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 2000 → All
Hardware: PC → All
Summary: Dependency graph wrong url path → Dependency graph wrong url path under mod_perl
Target Milestone: --- → Bugzilla 3.0

Comment 3

10 years ago
Max, maybe should we consider this bug for 3.0.1. This is a "regression" compared to 2.22.
(Assignee)

Comment 4

10 years ago
Yes, you're right. This is a pretty high priority to fix.
Assignee: dependency.views → mkanat
Flags: blocking3.0.1+
Priority: -- → P2
(Assignee)

Comment 5

10 years ago
Created attachment 273772 [details] [diff] [review]
v1

One-line fix. :-) Applied at:

http://landfill.bugzilla.org/mod_perl/
Attachment #273772 - Flags: review?(LpSolit)

Comment 6

10 years ago
Comment on attachment 273772 [details] [diff] [review]
v1

Looks good and doesn't break mod-cgi. r=LpSolit
Attachment #273772 - Flags: review?(LpSolit) → review+

Updated

10 years ago
Status: NEW → ASSIGNED
Flags: approval3.0+
Flags: approval+
(Assignee)

Comment 7

10 years ago
tip:

Checking in showdependencygraph.cgi;
/cvsroot/mozilla/webtools/bugzilla/showdependencygraph.cgi,v  <--  showdependencygraph.cgi
new revision: 1.62; previous revision: 1.61
done

3.0:

Checking in showdependencygraph.cgi;
/cvsroot/mozilla/webtools/bugzilla/showdependencygraph.cgi,v  <--  showdependencygraph.cgi
new revision: 1.56.2.3; previous revision: 1.56.2.2
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.