370426 - make mac toolbars look right in suiterunner

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Robert Kaiser]

This is a spinoff of bug 361159 Comment #12 and later comments.

When adding grippies to suiterunner toolbars in bug 361159, we discovered that bug 354644 introduced a hardcoded background for mac toolbars, which makes them look strange on systems where they are supposed to feature stripes. (Wasn't that what "pinstripe" was named after originally?)

While we're using -moz-appearance:toolbar on toolbars on other OSes, on mac we're doing that on the toolbox for no apparent reason and then use some hardcoded background on toolbars. This sounds like some ugly hack for something that should better be fixed on the nsITheme level or so.

This bug is to clear up those inconsistencies and make at least suiterunner (maybe toolkit itself) look "correctly" on mac wrt toolbars.

Comment 1

[Robert Kaiser]

http://lxr.mozilla.org/mozilla/source/themes/classic/global/mac/toolbar.css tells that xpfe has
toolbox { -moz-appearance: toolbox; }
toolbar { -moz-appearance: toolbar; }

We probably should have those in toolkit as well and make the "native theming" create the correct styles.

Comment 2

[Serge Gautherie (:sgautherie)]

Filter "spam" on "guifeatures-nobody-20080610".

Comment 3

[Stefan [:stefanh]]

Main toolbars are now unified by the patch in bug 460699, so I'm closing this as fixed.