370430 - [FIX]Adding or removing noframes element causes flashing

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect, P3)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See testcase, the page should not flash, but does in current builds (also on branch).
This regressed between 2005-09-05 and 2005-09-06, I think a regression from bug 306660.

Basically, the flashing happens when I add or remove the <noframes> element from the frameset page.
I'm seeing this also in non-dynamic cases, like at the url.

Comment 1

[Boris Zbarsky [:bzbarsky]]

The removal isn't flashing.  The addition is, because we reconstruct the whole frameset (and yes, that's a result of fixing bug 306660).

I suppose we could check for something that's not a frameset/frame here explicitly.  You'll still get flashing if you dynamically insert a frame or frameset.

Comment 2

[Martijn Wargers (dead)]

In reply to comment #1)
> I suppose we could check for something that's not a frameset/frame here
> explicitly.  You'll still get flashing if you dynamically insert a frame or
> frameset.

I guess that's a good idea, there is no way that any other element than <frame> or <frameset> get rendered, right?
That's why I specifically filed this bug. <noframes> typically nevers gets rendered at all in Mozilla, so I was surprised it had this kind of effect.

Comment 3

[Boris Zbarsky [:bzbarsky]]

> there is no way that any other element than <frame> or <frameset> get rendered, 
> right?

Right.  I agree that reframing when <noframes> gets moved about is silly.  ;)

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed fix

Comment 5

[Boris Zbarsky [:bzbarsky]]

I don't really know how to go about creating an automated test for this.  :(

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Is this worth doing? We're adding code to avoid reframes in a very special case. But reframes can still happen in general so the flashing problem can still happen.
I presume fixing that requires widget removal. But widget removal would also fix this. So why bother with this patch?

Comment 7

[Boris Zbarsky [:bzbarsky]]

In this case reframes are very expensive and lossy.  I think avoiding them if possible is very much worth it...

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 257003 [details] [diff] [review]
Proposed fix

Alright, given that this happens on a real site...

Comment 9

[Boris Zbarsky [:bzbarsky]]

Fixed.