370453 - Add a (debug only) warning when 'key' cannot be found

Status: RESOLVED FIXED

(Core :: XUL, enhancement)

Description

[Mats Palmgren (inactive)]

Add a (debug only) warning when 'key' cannot be found

It allows us to find real errors (I'll file them separately):

WARNING: Key 'historyHome' of menu item 'Home' could not be found: file nsMenuFrame.cpp, line 1520
WARNING: Key 'manBookmarkKb' of menu item 'Organize Bookmarks...' could not be found: file nsMenuFrame.cpp, line 1520

Comment 1

[Mats Palmgren (inactive)]

Attachment: Patch rev. 1

Comment 2

[[e-mail]]

Comment on attachment 255159 [details] [diff] [review]
Patch rev. 1

Might it be worth including the document URI perhaps?

Comment 3

[Mats Palmgren (inactive)]

(In reply to comment #2)
The current info should be enough to locate the bogus line I think. 

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 255159 [details] [diff] [review]
Patch rev. 1

s/NS_DEBUG/DEBUG/

And I'd do conversion to UTF8, not ASCII -- that way we can catch this in localized builds too.  ;)

sr=bzbarsky with that.

Comment 5

[Mats Palmgren (inactive)]

(In reply to comment #4)
> (From update of attachment 255159 [details] [diff] [review])
> s/NS_DEBUG/DEBUG/

Why?
I actually do prefer NS_DEBUG over DEBUG.  DEBUG seems a bit too generic
for us to assume it's unused.
Just grep-ing /usr/include shows several meanings for it and it could
cause problems for anyone that takes our code and mixes it with code
from other sources.

> And I'd do conversion to UTF8, not ASCII 

Will do.

Comment 6

[Boris Zbarsky [:bzbarsky]]

> Why?

Because almost all our debug code uses DEBUG, and --enable-debug enables both, and NS_DEBUG gets defined #ifdef DEBUG.  So they're really equivalent, and it's better not to pretend that NS_DEBUG is somehow better, imo...

Comment 7

[Mats Palmgren (inactive)]

Nits fixed. Checked in to trunk at 2007-02-23 21:42 PST

-> FIXED