370591 - Restrict history duration input with a formatter

Status: RESOLVED FIXED

(Camino Graveyard :: Preferences, defect)

Description

[Stuart Morgan]

Attachment: fix

We should be using a formatter to restrict the history duration pref input to the characters we want, rather than allowing arbitrary input and then beeping if we don't like it.

Comment 1

[Stuart Morgan]

Attachment: with more cleanup

Since I'm in there, some more cleanup for kicks.

I know I said I wouldn't do any more cleanup before 1.1, but I felt like writing this. It's not really risky since it's so self-contained, but it's also not likely to rot so I don't really care if it sits for a little while; your call.

Comment 2

[froodian (Ian Leue)]

Comment on attachment 255313 [details] [diff] [review]
with more cleanup

r=me, sorry about the wait.

Comment 3

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 255313 [details] [diff] [review]
with more cleanup

sr=pink

+  *anObject = [NSNumber numberWithInt:[string intValue]];
+  return YES;

what if |string| is something wonky and |-intValue| chokes and returns nil? Should we check |*anObject| for something valid before returning YES? Can intValue toss an exception?

Comment 4

[Stuart Morgan]

(In reply to comment #3)
> what if |string| is something wonky and |-intValue| chokes and returns nil?

intValue returns an int, not a number object; if it can't find anything numeric at the beginning of the string it returns 0, which is fine here.

Comment 5

[Stuart Morgan]

Checked in on trunk and MOZILLA_1_8_BRANCH